libbacktrace: fix build on Windows + resolve build requires conflicts #5575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
I've also tried to build libbacktrace with Visual Studio. After fighting with a build context and autotools parameters, I was able to pass configure step but compilation fails due to pointer arithmetic on void *: https://github.com/ianlancetaylor/libbacktrace/blob/dedbe13fda00253fe5d4f2fb812c909729ed5937/pecoff.c#L651 |
madebr
previously approved these changes
May 20, 2021
|
I have a patch to build libbacktrace with Visual Studio, but I don't know if it makes sense when unwind is not available at build time. |
it's worth noting that generated lib is quite limited in this case: projects calling backtrace_full and backtrace_simple functions will hit an error_callback with "no stack trace because unwind library not available"
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
madebr
reviewed
May 21, 2021
| @@ -0,0 +1,54 @@ | |||
| --- a/allocfail.c | |||
There was a problem hiding this comment.
Do you intend to upstream this patch?
There was a problem hiding this comment.
Not sure. I don't know if it really makes sense to support Visual Studio. I didn't fix all the files actually, only the ones built when libunwind is not found.
madebr
approved these changes
May 21, 2021
4 tasks
4 tasks
|
All green in build 6 (
|
SSE4
approved these changes
May 22, 2021
madebr
approved these changes
May 22, 2021
prince-chrismc
approved these changes
May 22, 2021
madebr
pushed a commit
to madebr/conan-center-index
that referenced
this pull request
Jun 21, 2021
…quires conflicts * fix build with MinGW on Windows * no os.rename * clarify invalid configuration message for Visual Studio * allow to build static lib with Visual Studio it's worth noting that generated lib is quite limited in this case: projects calling backtrace_full and backtrace_simple functions will hit an error_callback with "no stack trace because unwind library not available" * add -FS for Visual Studio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
conan-center hook activated.