add ms-gltf-sdk/1.9.5.0 #4557

SpaceIm · 2021-02-13T20:37:17Z

Specify library name and version: ms-gltf-sdk/1.9.5.0

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

It requires powershell at build time. It works on Macos, not tested on Linux.

conan-center-bot · 2021-02-13T21:39:05Z

All green in build 1 (bcb438d7568752da6b14cbc119cb993570e7867b):

gltf-sdk/1.9.5.0@:
All packages built successfully! (All logs)

recipes/gltf-sdk/all/conanfile.py

SpaceIm · 2021-02-14T12:16:26Z

recipes/ms-gltf-sdk/all/conanfile.py

+            raise ConanInvalidConfiguration("{} requires powershell at build time.".format(self.name))
+            self.build_requires("powershell/7.1.2")


waiting #4558

conan-center-bot · 2021-02-14T12:46:10Z

All green in build 2 (adbf788e45b94ebeba7cfc218fd7948603aed388):

ms-gltf-sdk/1.9.5.0@:
All packages built successfully! (All logs)

conan-center-bot · 2021-02-25T14:16:18Z

Failure in build 3 (bd56cf827dd1da535877e982ab017480840e440e):

ms-gltf-sdk/1.9.5.0@:
CI failed to create some packages (All logs)

Logs for packageID f6b529721f14d7184434362a25cf63ae882b419b:

[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=apple-clang
compiler.libcxx=libc++
compiler.version=9.1
os=Macos
os_build=Macos
[options]
ms-gltf-sdk:shared=False

********************************************************************************
conan install ms-gltf-sdk/1.9.5.0@ --profile=/Users/jenkins/w/BuildSingleReference/6809/9eeabe3d-ca5a-4146-b161-1b48008fd91c/profile.txt --build=ms-gltf-sdk
********************************************************************************
Configuration:
[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=apple-clang
compiler.libcxx=libc++
compiler.version=9.1
os=Macos
os_build=Macos
[options]
ms-gltf-sdk:shared=False
[build_requires]
[env]

ms-gltf-sdk/1.9.5.0: Forced build from source
powershell/7.1.2: Not found in local cache, looking in remotes...
powershell/7.1.2: Trying with 'conan-upstream'...
powershell/7.1.2: Trying with 'conan-center'...
ERROR: Failed requirement 'powershell/7.1.2' from 'ms-gltf-sdk/1.9.5.0'
ERROR: Unable to find 'powershell/7.1.2' in remotes

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

conan-center-bot · 2021-03-07T19:12:11Z

Failure in build 4 (bd56cf827dd1da535877e982ab017480840e440e):

ms-gltf-sdk/1.9.5.0@:
CI failed to create some packages (All logs)

Logs for packageID 7d85336d1b8d3a2a7a341faefac0a65e336f58c3:

[settings]
arch=x86_64
arch_build=x86_64
build_type=Debug
compiler=apple-clang
compiler.libcxx=libc++
compiler.version=10.0
os=Macos
os_build=Macos
[options]
ms-gltf-sdk:shared=False

********************************************************************************
conan install ms-gltf-sdk/1.9.5.0@ --profile=/Users/jenkins/w/BuildSingleReference@3/7274/ed265497-5565-4d18-ad17-4be20c2851ac/profile.txt --build=ms-gltf-sdk
********************************************************************************
Configuration:
[settings]
arch=x86_64
arch_build=x86_64
build_type=Debug
compiler=apple-clang
compiler.libcxx=libc++
compiler.version=10.0
os=Macos
os_build=Macos
[options]
ms-gltf-sdk:shared=False
[build_requires]
[env]

ms-gltf-sdk/1.9.5.0: Forced build from source
powershell/7.1.2: Not found in local cache, looking in remotes...
powershell/7.1.2: Trying with 'conan-upstream'...
powershell/7.1.2: Trying with 'conan-center'...
ERROR: Failed requirement 'powershell/7.1.2' from 'ms-gltf-sdk/1.9.5.0'
ERROR: Unable to find 'powershell/7.1.2' in remotes

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

This reverts commit bd56cf8.

SpaceIm · 2021-03-21T13:27:31Z

powershell is too tedious to package, so for now let's raise in build_requirements if powershell is not detected (it means no pre build packages on Linux & Macos). At least consumers can build from source if they have powershell installed.

conan-center-bot · 2021-03-21T13:34:50Z

Failure in build 5 (1753216f113dd4f7ec8bca0eafd540c39b7d50a5):

ms-gltf-sdk/1.9.5.0@:
Do not raise ConanInvalidConfiguration from build() method. Please, move that same check to validate() method.

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

SpaceIm · 2021-03-21T16:51:55Z

@uilianries @jgsogo I don't raise in build(), does hook also check build_requirements()?

conan-center-bot · 2021-04-05T10:13:26Z

Failure in build 6 (1753216f113dd4f7ec8bca0eafd540c39b7d50a5):

ms-gltf-sdk/1.9.5.0@:
Do not raise ConanInvalidConfiguration from build() method. Please, move that same check to validate() method.

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

jgsogo · 2021-04-05T10:13:38Z

Yes, the problem is related to the raise in the build_requirements. Conan resolves build-requirements only if it is going to build, and from our perspective that happens in the build() stage.

If PowerShell (#4558) is too hard to package, maybe we need to install powershell in the system (or consider creating a powershell/system recipe).

stale · 2021-05-05T18:23:51Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2021-06-04T18:39:00Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

add gltf-sdk/1.9.5.0

bcb438d

github-actions bot mentioned this pull request Feb 13, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

SpaceIm mentioned this pull request Feb 13, 2021

add powershell/7.1.2 #4558

Closed

4 tasks

SpaceIm marked this pull request as draft February 13, 2021 22:34

Croydon reviewed Feb 14, 2021

View reviewed changes

recipes/gltf-sdk/all/conanfile.py Outdated Show resolved Hide resolved

prince-chrismc previously approved these changes Feb 14, 2021

View reviewed changes

remane to ms-gtlf-sdk

adbf788

SpaceIm dismissed prince-chrismc’s stale review via adbf788 February 14, 2021 12:14

SpaceIm changed the title ~~add gltf-sdk/1.9.5.0~~ add ms-gltf-sdk/1.9.5.0 Feb 14, 2021

SpaceIm commented Feb 14, 2021

View reviewed changes

prince-chrismc previously approved these changes Feb 14, 2021

View reviewed changes

SSE4 requested a review from uilianries February 14, 2021 18:16

don't raise if powershell required

bd56cf8

SpaceIm dismissed prince-chrismc’s stale review via bd56cf8 February 25, 2021 13:59

conan-center-bot added the Failed label Feb 25, 2021

Revert "don't raise if powershell required"

1753216

This reverts commit bd56cf8.

SpaceIm marked this pull request as ready for review March 21, 2021 13:27

stale bot added the stale label May 5, 2021

stale bot closed this Jun 4, 2021

valgur mentioned this pull request Jan 26, 2024

Stale recipe PRs possibly worth another look #22553

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add ms-gltf-sdk/1.9.5.0 #4557

add ms-gltf-sdk/1.9.5.0 #4557

SpaceIm commented Feb 13, 2021 •

edited

Loading

conan-center-bot commented Feb 13, 2021

SpaceIm Feb 14, 2021

conan-center-bot commented Feb 14, 2021

conan-center-bot commented Feb 25, 2021

conan-center-bot commented Mar 7, 2021

SpaceIm commented Mar 21, 2021 •

edited

Loading

conan-center-bot commented Mar 21, 2021

SpaceIm commented Mar 21, 2021 •

edited

Loading

conan-center-bot commented Apr 5, 2021

jgsogo commented Apr 5, 2021

stale bot commented May 5, 2021

stale bot commented Jun 4, 2021

		raise ConanInvalidConfiguration("{} requires powershell at build time.".format(self.name))
		self.build_requires("powershell/7.1.2")

add ms-gltf-sdk/1.9.5.0 #4557

add ms-gltf-sdk/1.9.5.0 #4557

Conversation

SpaceIm commented Feb 13, 2021 • edited Loading

conan-center-bot commented Feb 13, 2021

SpaceIm Feb 14, 2021

Choose a reason for hiding this comment

conan-center-bot commented Feb 14, 2021

conan-center-bot commented Feb 25, 2021

conan-center-bot commented Mar 7, 2021

SpaceIm commented Mar 21, 2021 • edited Loading

conan-center-bot commented Mar 21, 2021

SpaceIm commented Mar 21, 2021 • edited Loading

conan-center-bot commented Apr 5, 2021

jgsogo commented Apr 5, 2021

stale bot commented May 5, 2021

stale bot commented Jun 4, 2021

SpaceIm commented Feb 13, 2021 •

edited

Loading

SpaceIm commented Mar 21, 2021 •

edited

Loading

SpaceIm commented Mar 21, 2021 •

edited

Loading