Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tssmsr/cci.20201117 #4552

Closed
wants to merge 2 commits into from
Closed

Add tssmsr/cci.20201117 #4552

wants to merge 2 commits into from

Conversation

remysalim
Copy link
Contributor

@remysalim remysalim commented Feb 12, 2021 •
edited
Loading

Specify library name and version: lib/1.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'tssmsr/cci.20201117' failed in build 1 (4c4fc17db2d6664fdc2568e0c9ab9e4d6b88e252):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'tssmsr/cci.20201117' failed in build 2 (7f6454cfdb628fdc5dc3a6b5c3b857e257cc3d31):

prince-chrismc
prince-chrismc suggested changes Feb 13, 2021
View reviewed changes
recipes/tssmsr/all/conanfile.py
def requirements(self):
# VC builds link against openssl included in the sources
if not self.settings.compiler == "Visual Studio":
self.requires("openssl/1.1.1g")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.requires("openssl/1.1.1g")
self.requires("openssl/1.1.1i")

recipes/tssmsr/all/conanfile.py
self.name, self._minimum_cpp_standard, self.settings.compiler, self.settings.compiler.version))

def requirements(self):
# VC builds link against openssl included in the sources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's different about the inline one? Typically we use a small patch to make sure it uses the Conan one

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just looks like an old one, you should be able to remove it and include the msbuild props generated from conan 🤞

recipes/tssmsr/all/conanfile.py

def package_info(self):
if tools.os_info.is_windows:
self.cpp_info.libs = ["tss.cpp"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/microsoft/TSS.MSR/blob/04eba4ac647c5fc2436adbeea49fc3372418de7b/TSS.CPP/TSS.CPP.vcxproj#L112

Suggested change
self.cpp_info.libs = ["tss.cpp"]
self.cpp_info.libs = ["tss.cpp"]
self.cpp_info.system_libs = ["ws2_32", "tbs.lib"]

@conan-center-bot
Copy link
Collaborator

Failure in build 3 (7f6454cfdb628fdc5dc3a6b5c3b857e257cc3d31):

  • tssmsr/cci.20201117@:
    CI failed to create some packages (All logs)

    Logs for packageID 061a1d1bc9992f229692ff79d974f9b79607398a: 
    [settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++
compiler.version=5
os=Linux
os_build=Linux

    include/TpmStructure.h: In instantiation of ‘static T TpmCpp::TpmStructure::fromBytes(const ByteVec&) [with T = TPM2B_DIGEST_KEYEDHASH; TpmCpp::ByteVec = std::vector<unsigned char>]’:
include/TpmTypes.h:16754:125:   required from here
include/TpmStructure.h:121:9: error: ‘class TPM2B_DIGEST_KEYEDHASH’ has no member named ‘initFromTpm’
         newObj.initFromTpm(buf);
         ^
In file included from include/Tpm2.h:19:0,
                 from Src/stdafx.h:32,
                 from Src/TpmDevice.cpp:6:
include/TpmMarshal.h: In instantiation of ‘T TpmCpp::TpmBuffer::createObj() [with T = TPM2B_DIGEST_SYMCIPHER]’:
include/TpmTypes.h:16724:106:   required from here
include/TpmMarshal.h:227:9: error: ‘class TPM2B_DIGEST_SYMCIPHER’ has no member named ‘initFromTpm’
         newObj.initFromTpm(*this);
         ^
In file included from include/TpmTypes.h:16:0,
                 from include/Tss.h:8,
                 from include/Tpm2.h:22,
                 from Src/stdafx.h:32,
                 from Src/TpmDevice.cpp:6:
include/TpmStructure.h: In instantiation of ‘static T TpmCpp::TpmStructure::fromBytes(const ByteVec&) [with T = TPM2B_DIGEST_SYMCIPHER; TpmCpp::ByteVec = std::vector<unsigned char>]’:
include/TpmTypes.h:16727:125:   required from here
include/TpmStructure.h:121:9: error: ‘class TPM2B_DIGEST_SYMCIPHER’ has no member named ‘initFromTpm’
         newObj.initFromTpm(buf);
         ^
In file included from include/Tpm2.h:19:0,
                 from Src/stdafx.h:32,
                 from Src/TpmDevice.cpp:6:
include/TpmMarshal.h: In instantiation of ‘T TpmCpp::TpmBuffer::createObj() [with T = TPM2B_DIGEST_KEYEDHASH]’:
include/TpmTypes.h:16751:106:   required from here
include/TpmMarshal.h:227:9: error: ‘class TPM2B_DIGEST_KEYEDHASH’ has no member named ‘initFromTpm’
         newObj.initFromTpm(*this);
         ^
In file included from include/TpmTypes.h:16:0,
                 from include/Tss.h:8,
                 from include/Tpm2.h:22,
                 from Src/stdafx.h:32,
                 from Src/TpmDevice.cpp:6:
include/TpmStructure.h: In instantiation of ‘static T TpmCpp::TpmStructure::fromBytes(const ByteVec&) [with T = TPM2B_DIGEST_KEYEDHASH; TpmCpp::ByteVec = std::vector<unsigned char>]’:
include/TpmTypes.h:16754:125:   required from here
include/TpmStructure.h:121:9: error: ‘class TPM2B_DIGEST_KEYEDHASH’ has no member named ‘initFromTpm’
         newObj.initFromTpm(buf);
         ^
make: *** [bin/obj/Src/release/TpmTypes.o] Error 1
make: *** [bin/obj/Src/release/TpmDevice.o] Error 1
[HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component openssl::openssl libdir "lib" does not contain any declared library
tssmsr/cci.20201117: WARN: Build folder is dirty, removing it: /home/conan/w/BuildSingleReference/.conan/data/tssmsr/cci.20201117/_/_/build/061a1d1bc9992f229692ff79d974f9b79607398a
tssmsr/cci.20201117: ERROR: Package '061a1d1bc9992f229692ff79d974f9b79607398a' build failed
tssmsr/cci.20201117: WARN: Build folder /home/conan/w/BuildSingleReference/.conan/data/tssmsr/cci.20201117/_/_/build/061a1d1bc9992f229692ff79d974f9b79607398a
ERROR: tssmsr/cci.20201117: Error in build() method, line 70
	args=[f"CONFIG={str(self.settings.build_type).lower()}", "-C", self._build_subfolder])
	ConanException: Error 2 while executing make 'CONFIG=release' '-C' 'source_subfolder/TSS.CPP' -j3

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@stale
Copy link

stale bot commented Apr 6, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 6, 2021
@stale
Copy link

stale bot commented May 6, 2021

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this May 6, 2021
@valgur valgur mentioned this pull request Jan 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc requested changes

Assignees
No one assigned
Labels
Failed stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remysalim @conan-center-bot @prince-chrismc