Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UTM to/from lat long convertor 0.9.8 #4202

Closed
wants to merge 3 commits into from

Conversation

shubhamck
Copy link

@shubhamck shubhamck commented Jan 10, 2021

Specify library name and version: utm_latlong_convertor/0.9.8

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Jan 10, 2021

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@shubhamck shubhamck changed the title Package UTM to/from lat long convertor Add UTM to/from lat long convertor 0.9.8 Jan 10, 2021
@conan-center-bot

This comment has been minimized.

1 similar comment
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Failure in build 4 (69b0d9725f2921a05c3dd2788f6211b816d1c0f1):

  • utm_latlong_convertor/0.9.8
    • 'conan export' command failed (ref 'utm_latlong_convertor/0.9.8'):

WARN: Remotes registry file missing, creating default one in /home/conan/w/cci_PR-4202/4/19007ab8-9b64-4570-b733-43dbd463959c/.conan/remotes.json
ERROR: Package recipe with name utm_latlong_convertor!=ofxgeo

#define RAD_TO_DEG (180.0/M_PI) """,)

def package_info(self):
# Original CMakeLists.txt exports "utm_latlong_convertor::utm_latlong_convertor" target:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a link? I don't see anything in upstream's source code.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry I think I just pasted this from other recipe files...will get rid of it thanks

Comment on lines +25 to +35
self.copy(pattern="LICENSE.md", dst="licenses",
src=self._source_subfolder)

self.copy(pattern="UTM.h", dst="include",
src=os.path.join(self._source_subfolder, "libs", "UTM", "include", "UTM"))

tools.replace_in_file(os.path.join(self.package_folder, "include", "UTM.h"),
"#include \"ofConstants.h\"", "// #include \"ofConstants.h\"")
tools.replace_in_file(os.path.join(self.package_folder, "include", "UTM.h"), "#define UTM_EP2 (UTM_E2/(1-UTM_E2)) ///< e'^2", """#define UTM_EP2 (UTM_E2/(1-UTM_E2)) ///< e'^2
#define DEG_TO_RAD (M_PI/180.0)
#define RAD_TO_DEG (180.0/M_PI) """,)
Copy link
Contributor

@SpaceIm SpaceIm Jan 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you build a lib? There are others public headers in this library, and .cpp files. But I guess it requires https://github.com/openframeworks/openFrameworks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the functionality to convert from UTM to Lat Lon is just this one file called UTM.h. Rest of the files have other functionalities which are non overlapping. So I thought of making it only a header-only with that one file. The replace_in_file is just a way around that dependancy on ofConstants.h.

It would be really helpful if you have a better and a cleaner solution in mind. Thanks :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 solutions:

  1. create a recipe for openFrameworks first, then create your recipe
  2. create your recipe as is, but add a TODO for full implementation of ofxgeo (which is not only this header file), and display a warning for consumers that this recipe is just a subset of ofxgeo.

@conan-center-bot
Copy link
Collaborator

Failure in build 5 (69b0d9725f2921a05c3dd2788f6211b816d1c0f1):

  • utm_latlong_convertor/0.9.8@:
    Error running command conan export "recipes/utm_latlong_convertor/all/conanfile.py" utm_latlong_convertor/0.9.8@:
    ERROR: Package recipe with name utm_latlong_convertor!=ofxgeo
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@stale
Copy link

stale bot commented Apr 6, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 6, 2021
@stale
Copy link

stale bot commented May 6, 2021

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants