Fix issue #3760 #3974

bowb · 2020-12-22T20:52:24Z

Specify library name and version: paho-mqtt-c/1.3.5

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

CLAassistant · 2020-12-22T20:52:27Z

All committers have signed the CLA.

conan-center-bot · 2020-12-22T20:52:46Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

ghost · 2020-12-22T20:54:45Z

I detected other pull requests that are modifying paho-mqtt-c/all recipe:

add paho-mqtt-c/1.3.8 #4063

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

conan-center-bot · 2020-12-22T21:07:41Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-12-22T21:13:29Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

madebr · 2020-12-22T21:31:59Z

recipes/paho-mqtt-c/all/conanfile.py

-        self.cpp_info.names["cmake_find_package"] = "eclipse-paho-mqtt-c"
-        self.cpp_info.names["cmake_find_package_multi"] = "eclipse-paho-mqtt-c"
+        self.cpp_info.names["cmake_find_package"] = "PahoMqttC"
+        self.cpp_info.names["cmake_find_package_multi"] = "PahoMqttC"


The thing is that paho-mqtt-c does not install cmake modules itself. So we don't know what the correct name is.
Granted, paho-mqtt-cpp uses PahoMqttC, but that's not official either.

There is no good solution ATM.
Conan should have a feature to rename these components for consumers.

Could you please add a comment/FIXME, saying that this name is used by paho-mqtt-cpp?

Hmm?

https://github.com/eclipse/paho.mqtt.c/blame/e047e25d34d53b4b265649144a3cac3b01eee76c/src/CMakeLists.txt#L308

@Croydon has better eyesight then me apparently. Thanks!

Looks like CMakeLists.txt from paho-mqtt-cpp is looking for PahoMqttC. I think this is where the error is coming from if set like this:

self.cpp_info.names["cmake_find_package"] = "eclipse-paho-mqtt-c"

https://github.com/eclipse/paho.mqtt.cpp/blob/a2e66455337a7e40277ca65ef2a3b045eb223c30/src/CMakeLists.txt#L26

It packs its own cmake module: https://github.com/eclipse/paho.mqtt.cpp/blob/a2e66455337a7e40277ca65ef2a3b045eb223c30/cmake/FindPahoMqttC.cmake

But that probably doesn't work with a static paho-mqtt-c library?

I think you're seeing this problem: eclipse-paho/paho.mqtt.cpp#264

I think the correct solution is to fix their cmake script and use the exported targets of paho.mqtt.c.
If you write the patch on top of their current master, maybe they accept it.

Looks like I'll have to take a look at the paho.mqtt.cpp issue. Thanks,

madebr · 2020-12-22T21:35:03Z

recipes/paho-mqtt-c/all/test_package/CMakeLists.txt


 if(PAHO_MQTT_C_ASYNC)
    add_executable(${PROJECT_NAME} test_package_async.c)
    if(PAHO_MQTT_C_WITH_SSL)
        if(PAHO_MQTT_C_SHARED)
-            target_link_libraries(${PROJECT_NAME} eclipse-paho-mqtt-c::paho-mqtt3as)
+            target_link_libraries(${PROJECT_NAME} PahoMqttC::paho-mqtt3as)


I haven't tested, but I think you can get away with using PahoMqttC::PahoMqttC.
That target will include all components (shared or static).
(I'm not 100% sure though)

Like this? Seems a bit redundant but it works with different build options.

if(PAHO_MQTT_C_ASYNC) add_executable(${PROJECT_NAME} test_package_async.c) if(PAHO_MQTT_C_WITH_SSL) if(PAHO_MQTT_C_SHARED) target_link_libraries(${PROJECT_NAME} PahoMqttC::PahoMqttC) else() target_link_libraries(${PROJECT_NAME} PahoMqttC::PahoMqttC) endif() else() if(PAHO_MQTT_C_SHARED) target_link_libraries(${PROJECT_NAME} PahoMqttC::PahoMqttC) else() target_link_libraries(${PROJECT_NAME} PahoMqttC::PahoMqttC) endif() endif() else() add_executable(${PROJECT_NAME} test_package_client.c) if(PAHO_MQTT_C_WITH_SSL) if(PAHO_MQTT_C_SHARED) target_link_libraries(${PROJECT_NAME} PahoMqttC::PahoMqttC) else() target_link_libraries(${PROJECT_NAME} PahoMqttC::PahoMqttC) endif() else() if(PAHO_MQTT_C_SHARED) target_link_libraries(${PROJECT_NAME} PahoMqttC::PahoMqttC) else() target_link_libraries(${PROJECT_NAME} PahoMqttC::PahoMqttC) endif() endif() endif()

You don't need the conditionals anymore.
But maybe ignore my suggestion and keep it as it was.

The test_package is testing the static/shared targets.
Let's keep it since it's not broken.

conan-center-bot · 2020-12-23T03:25:32Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-12-23T03:30:49Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-12-23T03:32:13Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-12-23T03:35:47Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

madebr · 2020-12-23T04:32:10Z

recipes/paho-mqtt-c/all/patches/0005-fix-cmake-static.patch

+
+             IF (NOT WIN32)
+-                SET_TARGET_PROPERTIES(paho-mqtt3a-static PROPERTIES OUTPUT_NAME paho-mqtt3a)
+                SET_TARGET_PROPERTIES(paho-mqtt3a-static PROPERTIES OUTPUT_NAME paho-mqtt3a-static)


Instead of a patch, it's also perfectly fine to only add the -static suffix in package_info when on Windows.
e.g.

if not self.options.shared and self.settings.os == "Windows": target += "-static"

This is probably done to avoid mixing up a static library and an import library.

Is this suppose to change the generated library name? There is already a _cmake_target defined but it doesn't appear to change the generated library name. I also don't know if -static needs to be added for a windows build. The _cmake_target hints that does need -static for windows.

self.cpp_info.components["_paho-mqtt-c"].names["cmake_find_package"] = self._cmake_target self.cpp_info.components["_paho-mqtt-c"].names["cmake_find_package_multi"] = self._cmake_target def _cmake_target(self): target = "paho-mqtt3" target += "a" if self.options.asynchronous else "c" if self.options.ssl: target += "s" if not self.options.shared: target += "-static" return target

OUTPUT_NAME sets the name of the output file.

You can do something as follows (untested):

def _cmake_target(self): target = "paho-mqtt3" target += "a" if self.options.asynchronous else "c" if self.options.ssl: target += "s" if self.settings.os != "Windows" and not self.options.shared: target += "-static" return target

recipes/pthreads4w/all/conanfile.py

conan-center-bot · 2020-12-23T16:31:59Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-12-29T11:12:06Z

config.yml syntax error in build 9:

Only one library can be changed in the same PR: [paho-mqtt-c/all, paho-mqtt-cpp/all, pthreads4w/all]|

a4z · 2021-01-02T22:06:01Z

I have closed #3834 since there is now 1.3.8 and this should be used, 1.3.6 has. known bugs and limitations.
possible you want to consider to change the recipe so it works with 1.3.8
however, when the C++ lib will be adopted, no one knows, the maintainer does not use the lib himself, so progress is very slow.
And I do not think it is possible to update both recipes in the same PR, so you might want to adopt that

conan-center-bot · 2021-01-04T17:21:57Z

config.yml syntax error in build 10:

Only one library can be changed in the same PR: [paho-mqtt-c/all, pthreads4w/all]|

bowb · 2021-01-04T17:51:12Z

I'm going to rework this. Closing.

conan-center-bot added the No Beta user label Dec 22, 2020

bowb mentioned this pull request Dec 22, 2020

[package] paho-mqtt-cpp/1.1: build fails with error "Could NOT find PahoMqttC (missing: PAHO_MQTT_C_LIBRARIES)" #3760

Closed

ghost mentioned this pull request Dec 22, 2020

[service] Potentially conflicting recipes #3571

Closed

ghost mentioned this pull request Dec 22, 2020

update paho-mqtt-c to 1.3.7 #3834

Closed

4 tasks

madebr reviewed Dec 22, 2020

View reviewed changes

madebr reviewed Dec 23, 2020

View reviewed changes

recipes/pthreads4w/all/conanfile.py Outdated Show resolved Hide resolved

conan-center-bot removed the No Beta user label Dec 29, 2020

conan-center-bot added the Failed label Dec 29, 2020

ghost mentioned this pull request Jan 4, 2021

add paho-mqtt-c/1.3.8 #4063

Merged

4 tasks

cleanup.

906879b

bowb closed this Jan 4, 2021

bowb deleted the paho-mqtt-c/1.3.5 branch January 4, 2021 17:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issue #3760 #3974

Fix issue #3760 #3974

bowb commented Dec 22, 2020 •

edited

Loading

CLAassistant commented Dec 22, 2020 •

edited

Loading

conan-center-bot commented Dec 22, 2020

ghost commented Dec 22, 2020 •

edited by ghost

Loading

conan-center-bot commented Dec 22, 2020

conan-center-bot commented Dec 22, 2020

madebr Dec 22, 2020

Croydon Dec 22, 2020

madebr Dec 22, 2020

bowb Dec 22, 2020 •

edited

Loading

madebr Dec 22, 2020

madebr Dec 22, 2020

bowb Dec 22, 2020

madebr Dec 22, 2020

bowb Dec 22, 2020

madebr Dec 22, 2020

conan-center-bot commented Dec 23, 2020

conan-center-bot commented Dec 23, 2020

conan-center-bot commented Dec 23, 2020

conan-center-bot commented Dec 23, 2020

madebr Dec 23, 2020 •

edited

Loading

bowb Dec 23, 2020

madebr Dec 27, 2020

conan-center-bot commented Dec 23, 2020

conan-center-bot commented Dec 29, 2020

a4z commented Jan 2, 2021

conan-center-bot commented Jan 4, 2021

bowb commented Jan 4, 2021

Fix issue #3760 #3974

Fix issue #3760 #3974

Conversation

bowb commented Dec 22, 2020 • edited Loading

CLAassistant commented Dec 22, 2020 • edited Loading

conan-center-bot commented Dec 22, 2020

ghost commented Dec 22, 2020 • edited by ghost Loading

conan-center-bot commented Dec 22, 2020

conan-center-bot commented Dec 22, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bowb Dec 22, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conan-center-bot commented Dec 23, 2020

conan-center-bot commented Dec 23, 2020

conan-center-bot commented Dec 23, 2020

conan-center-bot commented Dec 23, 2020

madebr Dec 23, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conan-center-bot commented Dec 23, 2020

conan-center-bot commented Dec 29, 2020

a4z commented Jan 2, 2021

conan-center-bot commented Jan 4, 2021

bowb commented Jan 4, 2021

bowb commented Dec 22, 2020 •

edited

Loading

CLAassistant commented Dec 22, 2020 •

edited

Loading

ghost commented Dec 22, 2020 •

edited by ghost

Loading

bowb Dec 22, 2020 •

edited

Loading

madebr Dec 23, 2020 •

edited

Loading