libwebm: add webm directory to include path #26029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Header files of libweb include others without 'webm' path prefix. So if I include any header or libwebm with INCLUDE_PATH to 'include' dir only, it can not resolve other libwebm headers. In my case it fails to compile on macos
|
|
|
@niktischenko Hello and thank you for your bugfix! Could you please share your full build log with the reported error? It's important tracking not only changes, but their motivation too, so we can understand better for any future change. |
In generated webm-debug-arm64-data.cmake: |
uilianries
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
LGTM. Indeed public headers are expecting the webm folder as well in the include path: https://chromium.googlesource.com/webm/libwebm/+/refs/tags/libwebm-1.0.0.31/mkvmuxer/mkvmuxer.h
Thank you for your hotfix!!
memsharded
pushed a commit
to toge/conan-center-index
that referenced
this pull request
Nov 29, 2024
OMGtechy
pushed a commit
to OMGtechy/conan-center-index
that referenced
this pull request
Dec 31, 2024
jcar87
added a commit
that referenced
this pull request
Jan 10, 2025
* re2c: add version 4.0 * update 4.0.1 * changing to CMake build * dropping 1.3 * remove config.yml entry * simdutf: add version 5.6.3 (#26039) * SDL: fix Android shared library and expose HIDAPI setting (#26049) * arrow: add version 18.1.0 (#26035) * libwebm: add webm directory to include path (#26029) * libpsl: add v0.21.5, bump deps, simplify patching (#22029) * libpsl: add v0.21.2, bump deps, simplify patching * libpsl: rmdir share * libpsl: bump to v0.21.5 * cleanup * Automaticlly injected in Conan 2 * Using option. Using the old patch * Update recipes/libpsl/all/conanfile.py --------- Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es> Co-authored-by: Francisco Ramirez de Anton <franchuti688@gmail.com> * json_struct receipt (#25335) * tree-sitter-sql: add version 0.3.7 (#26012) * OpenColorIO: Fix validation & package_info (#24395) * OpenColorIO: Fix validation & package_info * Remove the validation preventing shared building * Add required libraries to package_info * update recipe * fix linux transitive shared * try to remove redundant requires * fix previous versions * removed versions from config.yml * more fixes previous versions --------- Co-authored-by: memsharded <james@conan.io> * openh264: add version 2.5.0 (#26044) Co-authored-by: PerseoGI <perseog@jfrog.com> Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es> * glib: Bump libmount to 2.39.2 to avoid conflicts with libsystemd (#23030) Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com> Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es> Co-authored-by: Abril Rincón Blanco <rubenrb@jfrog.com> * sqlite3: add 3.47.1 (#26043) * removing old 2.0.3 * update 4.0.2 * re2c updates * fix test_package conanfile --------- Co-authored-by: memsharded <james@conan.io> Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es> Co-authored-by: Andrey Filipenkov <decapitator@ukr.net> Co-authored-by: Bryce Mecum <petridish@gmail.com> Co-authored-by: Nikolay Tischenko <niktischenko@gmail.com> Co-authored-by: Martin Valgur <martin.valgur@gmail.com> Co-authored-by: Francisco Ramirez de Anton <franchuti688@gmail.com> Co-authored-by: Jørgen Lind <jorgen.lind@gmail.com> Co-authored-by: Ingmar Rieger <git@irieger.net> Co-authored-by: PerseoGI <perseog@jfrog.com> Co-authored-by: Jordan Williams <jordan@jwillikers.com> Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com> Co-authored-by: Abril Rincón Blanco <rubenrb@jfrog.com> Co-authored-by: Marian Klymov <nekto1989@gmail.com> Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header files of libweb include others without 'webm' path prefix. So if I include any header or libwebm with INCLUDE_PATH to 'include' dir only, it can not resolve other libwebm headers.
In my case it fails to compile on macos
Summary
Changes to recipe: libwebm/1.0.0.31
Motivation
Compilation error on macos due to insufficient include path
Details
Headers of libweb include others without webm prefix, which is required with current cpp_info.includedirs set