Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crossdb: add recipe #25704

Merged
merged 13 commits into from
Oct 31, 2024
Merged

crossdb: add recipe #25704

merged 13 commits into from
Oct 31, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented Oct 23, 2024

Summary

Changes to recipe: crossdb/0.9.0

Motivation

yet another embedded RDB library.

Details

https://github.com/crossdb-org/crossdb


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Minor comment about the test_package, otherwise I think this looks good :)

@AbrilRBS AbrilRBS self-assigned this Oct 24, 2024
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 7ee3722
crossdb/0.9.0@#cef295ebbc2881be727168c5c5e8e159
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libcrossdb.dylib

@conan-center-bot

This comment has been minimized.

AbrilRBS
AbrilRBS previously approved these changes Oct 29, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit e8c3d17
crossdb/0.9.0@#f4d391b86d58306b856cc7f3ed30f768
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libcrossdb.dylib

@conan-center-bot

This comment has been minimized.

AbrilRBS
AbrilRBS previously approved these changes Oct 29, 2024
@uilianries uilianries self-assigned this Oct 31, 2024
recipes/crossdb/all/test_package/test_package.c Outdated Show resolved Hide resolved
recipes/crossdb/all/conanfile.py Outdated Show resolved Hide resolved
recipes/crossdb/all/conanfile.py Show resolved Hide resolved
recipes/crossdb/all/conanfile.py Outdated Show resolved Hide resolved
recipes/crossdb/all/conanfile.py Show resolved Hide resolved
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@toge I did few changes simplifying the test package and using fix_apple_shared_install_name instead.

The project looks really simple and is pure-c. Thank you for your PR.

@uilianries
Copy link
Member

The Conan 1.x shows as failed, but is actually running. Should report the build result in ~10min.

@uilianries uilianries requested a review from AbrilRBS October 31, 2024 11:07
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 11 (e1b87747602f662d30b42cdd3057c6dd387fd8f7):

  • crossdb/0.9.0:
    Built 8 packages out of 11 (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 11 (e1b87747602f662d30b42cdd3057c6dd387fd8f7):

  • crossdb/0.9.0:
    Built 3 packages out of 10 (All logs)

@toge
Copy link
Contributor Author

toge commented Oct 31, 2024

@uilianries
Thank you for your improvements!
I learned your contribution a lot!

@conan-center-bot conan-center-bot merged commit 22589c7 into conan-io:master Oct 31, 2024
8 checks passed
OMGtechy pushed a commit to OMGtechy/conan-center-index that referenced this pull request Dec 31, 2024
* crossdb: add recipe

* drop MSVC support

* simplify test_package.c

* Update recipes/crossdb/all/conanfile.py

* make rpath on macOS

* Simplify test package

* Avoid emojis in the recipe.

* Use fix_apple_shared_install_name to fix rpath

* Do not enforce CMAKE_MACOSX_RPATH

* Import fix_apple_shared_install_name

---------

Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants