-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xerces-c: fix handling of nsl library #25593
Conversation
We ensured this was the case for our images in conan-io/conan-docker-tools#584, however I suspect some of the Conan 1.x docker images are still legacy and not configured with this - otherwise the hook warning would not have been triggered. I can confirmed that the Conan 2.x packages we published DO NOT encode a dependency on libnsl for the shared variant - so that's another indicator that it is not needed. also the upstream .pc file does not mention this: |
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 ( |
Hooks produced the following warnings for commit 6bc24faxerces-c/3.2.5@#4534bf5ce931e79773601ba912a963a6
xerces-c/3.2.3@#1f255728b15165538b7c364a117ff5a4
xerces-c/3.2.4@#bf517826057577a146f6efe0f3ec43ff
xerces-c/3.2.2@#e8a15e95f42afa20871a66ca880593bd
|
Summary
Changes to recipe: xerces-c all
Motivation
nsl is not a system library that is installed by default or found in all distros - so it shouldn't be listed as a system dependency without further safeguards.
Details
However, nsl appears to be completely unused even when found by the build system (there are no evaluations of the
HAVE_LIBNSL
macro, and no uses of any headers in therpcsvc/*
folder.On systms where gcc is configured to pass
--as-needed
to the linker, the dependency is never encoded even if libnsl was found.