[premake] Build with Conan 1.x again #25131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
valgur
approved these changes
Sep 4, 2024
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Done! 😄 |
AbrilRBS
approved these changes
Sep 4, 2024
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 (
|
3 tasks
valgur
approved these changes
Sep 4, 2024
3 tasks
OMGtechy
pushed a commit
to OMGtechy/conan-center-index
that referenced
this pull request
Dec 31, 2024
* Re-enable Conan 1.x build Signed-off-by: Uilian Ries <uilianries@gmail.com> * Remove unused import Signed-off-by: Uilian Ries <uilianries@gmail.com> --------- Signed-off-by: Uilian Ries <uilianries@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: premake/alpha-15
Motivation
So far, Conan 1.x is still mandatory for recipes that are present in ConanCenterIndex since before Conan 2.x migration.
The premake failed previously, but I can not reproduce that same error by running it in an equal docker container.
Details
Using the Docker image
conanio/clang13-ubuntu16.04:1.65.0, I see no errors when building in Debug mode:premake-alpha15-clang13-debug.log