Change default disable_static_registration to True for onnx #25078
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onnxruntime forces this to be True for building: https://github.com/microsoft/onnxruntime/blob/be76e1e1b8e2914e448d12a0cc683c00014c0490/cmake/external/onnxruntime_external_deps.cmake#L542
The problem is that we can't do this right now in Conan Center Index for the onnxruntime recipe:
Because we would get missing binaries, and if we raise Invalid Configuration then we won't actually build onnxruntime.
As the only recipe that uses onnx y Conan Center Index is onnxruntime and for that case we need to set this. I think it's better to change the default for the upstream and use
True
for this option.Also related with: #22557