Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default disable_static_registration to True for onnx #25078

Merged

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Aug 29, 2024

onnxruntime forces this to be True for building: https://github.com/microsoft/onnxruntime/blob/be76e1e1b8e2914e448d12a0cc683c00014c0490/cmake/external/onnxruntime_external_deps.cmake#L542

The problem is that we can't do this right now in Conan Center Index for the onnxruntime recipe:

    def configure(self):
        if self.options.shared:
            self.options.rm_safe("fPIC")
        self.options["onnx"].disable_static_registration = True

Because we would get missing binaries, and if we raise Invalid Configuration then we won't actually build onnxruntime.

As the only recipe that uses onnx y Conan Center Index is onnxruntime and for that case we need to set this. I think it's better to change the default for the upstream and use True for this option.

Also related with: #22557

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (870a0fdc7a99eb6199bc7a55ead9b6f4ca029d8e):

  • onnx/1.16.2:
    All packages built successfully! (All logs)

  • onnx/1.16.1:
    All packages built successfully! (All logs)

  • onnx/1.16.0:
    All packages built successfully! (All logs)

  • onnx/1.15.0:
    All packages built successfully! (All logs)

  • onnx/1.13.1:
    All packages built successfully! (All logs)

  • onnx/1.14.0:
    All packages built successfully! (All logs)

  • onnx/1.14.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (870a0fdc7a99eb6199bc7a55ead9b6f4ca029d8e):

  • onnx/1.16.2:
    All packages built successfully! (All logs)

  • onnx/1.16.1:
    All packages built successfully! (All logs)

  • onnx/1.16.0:
    All packages built successfully! (All logs)

  • onnx/1.13.1:
    All packages built successfully! (All logs)

  • onnx/1.14.1:
    All packages built successfully! (All logs)

  • onnx/1.14.0:
    All packages built successfully! (All logs)

  • onnx/1.15.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 819c75e into conan-io:master Aug 29, 2024
36 checks passed
OMGtechy pushed a commit to OMGtechy/conan-center-index that referenced this pull request Dec 31, 2024
…or onnx

* change default disable_static_registration

* empty commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants