Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC][APR] Support for cross-building using configuration variables #24329
[POC][APR] Support for cross-building using configuration variables #24329
Changes from 3 commits
4cbcbd1
c9573b4
a3b5e0d
cf655e4
dec6327
3b6b1b0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For ` "ac_cv_file__dev_zero=yes", "ac_cv_mmap__dev_zero=yes":
/dev/zero
and it should bemmap
'able, and but fairly certainmmap
also supports zeroing with with theMAP_ANONYMOUS
flag - so on Linux I think these two checks areyes
almost universally.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprised this check needs any runtime anything, fairly certain it just checks that the
PTHREAD_PROCESS_SHARED
macro is defined in pthread.h - this seems part of Posix and I can't find examples of this not being defined on Linux. Very much not the case on windows thoughThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tcpcork is available on Linux since kernel 2.2 released in 1999
https://linux.die.net/man/7/tcp
So I think we can also assume that this is available - the check is more useful keeping in mind that apr is quite old and aims to support things like solaris, sunOS, etc
Check warning on line 190 in recipes/apr/all/conanfile.py
GitHub Actions / Lint changed conanfile.py (v2 migration)
Check warning on line 195 in recipes/apr/all/conanfile.py
GitHub Actions / Lint changed conanfile.py (v2 migration)
Check warning on line 211 in recipes/apr/all/conanfile.py
GitHub Actions / Lint changed conanfile.py (v2 migration)