-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libgit2: add version 1.8.1 #23953
Merged
Merged
libgit2: add version 1.8.1 #23953
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
diff --git a/cmake/SelectHTTPParser.cmake b/cmake/SelectHTTPParser.cmake | ||
index 955aea3..ff94eb8 100644 | ||
--- a/cmake/SelectHTTPParser.cmake | ||
+++ b/cmake/SelectHTTPParser.cmake | ||
@@ -1,10 +1,10 @@ | ||
# Optional external dependency: http-parser | ||
if(USE_HTTP_PARSER STREQUAL "system") | ||
- find_package(HTTPParser) | ||
+ find_package(http_parser) | ||
|
||
- if(HTTP_PARSER_FOUND AND HTTP_PARSER_VERSION_MAJOR EQUAL 2) | ||
- list(APPEND LIBGIT2_SYSTEM_INCLUDES ${HTTP_PARSER_INCLUDE_DIRS}) | ||
- list(APPEND LIBGIT2_SYSTEM_LIBS ${HTTP_PARSER_LIBRARIES}) | ||
+ if(http_parser_FOUND) | ||
+ list(APPEND LIBGIT2_SYSTEM_INCLUDES ${http_parser_INCLUDE_DIRS}) | ||
+ list(APPEND LIBGIT2_SYSTEM_LIBS ${http_parser_LIBRARIES}) | ||
list(APPEND LIBGIT2_PC_LIBS "-lhttp_parser") | ||
add_feature_info(http-parser ON "http-parser support (system)") | ||
else() | ||
diff --git a/cmake/SelectHTTPSBackend.cmake b/cmake/SelectHTTPSBackend.cmake | ||
index d293001..acffba9 100644 | ||
--- a/cmake/SelectHTTPSBackend.cmake | ||
+++ b/cmake/SelectHTTPSBackend.cmake | ||
@@ -9,6 +9,11 @@ if(CMAKE_SYSTEM_NAME MATCHES "Darwin") | ||
endif() | ||
|
||
if(USE_HTTPS) | ||
+ if(WIN32) | ||
+ list(APPEND LIBGIT2_SYSTEM_LIBS "secur32") | ||
+ list(APPEND LIBGIT2_PC_LIBS "-lsecur32") | ||
+ endif() | ||
+ | ||
# Auto-select TLS backend | ||
sanitizebool(USE_HTTPS) | ||
if(USE_HTTPS STREQUAL ON) | ||
diff --git a/cmake/SelectSSH.cmake b/cmake/SelectSSH.cmake | ||
index 079857f..652b310 100644 | ||
--- a/cmake/SelectSSH.cmake | ||
+++ b/cmake/SelectSSH.cmake | ||
@@ -4,15 +4,11 @@ if(USE_SSH STREQUAL "exec") | ||
|
||
add_feature_info(SSH ON "using OpenSSH exec support") | ||
elseif(USE_SSH STREQUAL ON OR USE_SSH STREQUAL "libssh2") | ||
- find_pkglibraries(LIBSSH2 libssh2) | ||
- | ||
- if(NOT LIBSSH2_FOUND) | ||
- find_package(LibSSH2) | ||
- set(LIBSSH2_INCLUDE_DIRS ${LIBSSH2_INCLUDE_DIR}) | ||
- get_filename_component(LIBSSH2_LIBRARY_DIRS "${LIBSSH2_LIBRARY}" DIRECTORY) | ||
- set(LIBSSH2_LIBRARIES ${LIBSSH2_LIBRARY}) | ||
- set(LIBSSH2_LDFLAGS "-lssh2") | ||
- endif() | ||
+ FIND_PACKAGE(Libssh2 REQUIRED) | ||
+ SET(LIBSSH2_FOUND ON) | ||
+ SET(LIBSSH2_INCLUDE_DIRS ${Libssh2_INCLUDE_DIRS}) | ||
+ SET(LIBSSH2_LIBRARIES ${Libssh2_LIBRARIES}) | ||
+ SET(LIBSSH2_LIBRARY_DIRS ${Libssh2_LIB_DIRS}) | ||
|
||
if(NOT LIBSSH2_FOUND) | ||
message(FATAL_ERROR "LIBSSH2 not found. Set CMAKE_PREFIX_PATH if it is installed outside of the default search path.") | ||
@@ -22,10 +18,7 @@ elseif(USE_SSH STREQUAL ON OR USE_SSH STREQUAL "libssh2") | ||
list(APPEND LIBGIT2_SYSTEM_LIBS ${LIBSSH2_LIBRARIES}) | ||
list(APPEND LIBGIT2_PC_LIBS ${LIBSSH2_LDFLAGS}) | ||
|
||
- check_library_exists("${LIBSSH2_LIBRARIES}" libssh2_userauth_publickey_frommemory "${LIBSSH2_LIBRARY_DIRS}" HAVE_LIBSSH2_MEMORY_CREDENTIALS) | ||
- if(HAVE_LIBSSH2_MEMORY_CREDENTIALS) | ||
- set(GIT_SSH_LIBSSH2_MEMORY_CREDENTIALS 1) | ||
- endif() | ||
+ set(GIT_SSH_MEMORY_CREDENTIALS 1) | ||
|
||
if(WIN32 AND EMBED_SSH_PATH) | ||
file(GLOB SSH_SRC "${EMBED_SSH_PATH}/src/*.c") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
versions: | ||
"1.8.0": | ||
folder: "all" | ||
"1.7.2": | ||
folder: "all" | ||
"1.5.0": | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This keeps the same old behaviour as per libgit2/libgit2@v1.7.2...v1.8.0#diff-95a55896bed1a5af65001605d4d237f52bed5366bd33d43528638dc756e26efbR7, thanks!