Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libelfin: refactor test package #23936

Merged
merged 1 commit into from
May 9, 2024
Merged

libelfin: refactor test package #23936

merged 1 commit into from
May 9, 2024

Conversation

ErniGH
Copy link
Contributor

@ErniGH ErniGH commented May 9, 2024

Simplify the test_package in according to our policies:

  • Write the minimal test that tests the package (the compiler can find the correct includes, the static linker can resolve
    symbols, the runtime linker can resolve symbols).
  • Do not perform heavy logic in CI.
  • Remove binary blob - these have not been allowed anywhere in the repository for a while now, it's time to drop them where they exist

@prince-chrismc prince-chrismc mentioned this pull request May 9, 2024
Open
@AbrilRBS AbrilRBS self-assigned this May 9, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (bafdd6dab84f271cf8f1bc5f74bb9690ef3021d3):

  • libelfin/0.3:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (bafdd6dab84f271cf8f1bc5f74bb9690ef3021d3):

  • libelfin/0.3:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less is more

@conan-center-bot conan-center-bot merged commit 8300f53 into conan-io:master May 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@uilianries uilianries uilianries approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ErniGH @conan-center-bot @uilianries @AbrilRBS