Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libwebsockets: drop dead code #23853

Merged
merged 4 commits into from
May 9, 2024
Merged

libwebsockets: drop dead code #23853

merged 4 commits into from
May 9, 2024

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented May 3, 2024 •
edited
Loading

version is always >=4.2.0
since 203af45

Specify library name and version: libwebsockets/*

fixes #23899

@ericLemanissier
libwebsockets: drop dead code
be026cf 
version is always >=4.2.0
since conan-io@203af45
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc prince-chrismc mentioned this pull request May 3, 2024
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@jcar87 jcar87 self-assigned this May 3, 2024
@ericLemanissier ericLemanissier mentioned this pull request May 7, 2024
Closed
@ericLemanissier
Copy link
Contributor Author

ericLemanissier commented May 7, 2024 •
edited
Loading

builds with -o libwebsockets/*:with_ssl=False pass on https://github.com/eirikb/proof-of-conan/actions/runs/8982026622/job/24668759596 (appart from 4.2.1 and 4.2.0 on windows, which do not have this fix warmcat/libwebsockets@af501ea

@conan-center-bot

This comment has been minimized.

Sign in to view
@ericLemanissier @jcar87
Apply suggestions from code review
98b53a8 
Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (98b53a861e0cea63c80eb11e2ec4d43284e0184b):

  • libwebsockets/4.3.3:
    All packages built successfully! (All logs)

  • libwebsockets/4.3.2:
    All packages built successfully! (All logs)

  • libwebsockets/4.3.0:
    All packages built successfully! (All logs)

  • libwebsockets/4.2.1:
    All packages built successfully! (All logs)

  • libwebsockets/4.2.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (98b53a861e0cea63c80eb11e2ec4d43284e0184b):

  • libwebsockets/4.3.3:
    All packages built successfully! (All logs)

  • libwebsockets/4.3.0:
    All packages built successfully! (All logs)

  • libwebsockets/4.3.2:
    All packages built successfully! (All logs)

  • libwebsockets/4.2.1:
    All packages built successfully! (All logs)

  • libwebsockets/4.2.0:
    All packages built successfully! (All logs)

@ericLemanissier ericLemanissier requested a review from jcar87 May 9, 2024 06:11
@conan-center-bot conan-center-bot merged commit f340809 into conan-io:master May 9, 2024
33 checks passed
@ericLemanissier ericLemanissier deleted the patch-13 branch May 9, 2024 19:35
robinnorthcottqube
robinnorthcottqube reviewed May 13, 2024
View reviewed changes
recipes/libwebsockets/all/conanfile.py
Comment on lines -242 to -243
if ("Visual" in str(self.settings.compiler.version) and Version(self.settings.compiler.version) < 16) or \
("msvc" == str(self.settings.compiler.version) and Version(self.settings.compiler.version) < 192):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a logic change. I think it should also check that the compiler is msvc? I'm getting validation fails here when building with gcc 13.2.0

libwebsockets/4.3.3: Invalid: libwebsockets/4.3.3 requires at least Visual Studio 2019

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually shouldn't it be not ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woopsie, all configurations are invalid indeed. Don't hesitate to make a PR fixing the error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinnorthcottqube robinnorthcottqube robinnorthcottqube left review comments

@jcar87 jcar87 jcar87 approved these changes

@Croydon Croydon Croydon approved these changes

Assignees

@jcar87 jcar87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libwebsockets: error building when not using OpenSSL
5 participants
@ericLemanissier @conan-center-bot @Croydon @jcar87 @robinnorthcottqube