-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assimp: add v5.4.1 #23735
assimp: add v5.4.1 #23735
Conversation
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit d05adc0assimp/5.4.0@#2e500b9b6a6ee6fa518ef039da5e00f2
assimp/5.2.5@#00b00174c78834f0d70c837ff033d943
assimp/5.3.1@#d526496053e32e6fba656bb259a34035
assimp/5.2.2@#510da41e7ae1bd4ac1608fa26b51cc61
assimp/5.1.6@#1c4559a6f6cebedcb1dea81c292b7475
|
Should we ensure we don't get bitten by changes like assimp/assimp@v5.3.1...v5.4.0#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR140 in the future? |
@RubenRBS Thanks for catching that. I added explicit handling of all relevant CMake options. |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 1a9db0bassimp/5.4.0@#1d2a20647ea14a07e510d8bd6767f737
assimp/5.3.1@#e91fc38f245a2ca02360595b5a00d42d
assimp/5.2.5@#5c5957a06229b332fc6b45639c61f51e
assimp/5.2.2@#5623ae58998e94a137e333047b3426f1
assimp/5.1.6@#23eecdd5674d467f944ce6af57ece733
|
https://github.com/assimp/assimp/releases/tag/v5.4.1 5.4.1 has just been released and addresses some Draco relating issues. Could it be related to the warnings emitted above? |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 2cf3a45assimp/5.4.1@#3bb2349246221841ad1e1ecb33c67cd5
|
@valgur thanks for bumping this so fast. Out of interest, do you know whether the warnings in the build is what's holding up the merging of this PR? Or is just the queue taking its time? |
@sunbubble The queue of open PRs is simply very long (https://github.com/ericLemanissier/conan-center-index-pending-review/issues/3), although simple PRs like this one usually get reviewed faster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @valgur :)
Minor question, otherwise looks good
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 83c15acassimp/5.4.1@#0246f50c320eb797a5ae6aaa5eeda622
|
This reverts commit 83c15ac.
This comment has been minimized.
This comment has been minimized.
I'm seeing some Are we thus not patching things properly? |
@RubenRBS The logic was correct, but I cleaned up the patching to avoid the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Conan v1 pipeline ✔️All green in build 6 (
Conan v2 pipeline ✔️
All green in build 6 ( |
Hooks produced the following warnings for commit 85cfebfassimp/5.4.1@#669250f69a5b55c5a7a6eb9b7183bffd
assimp/5.3.1@#0835bb213b5fe846fa5f3b325f9bde46
assimp/5.2.5@#e4f72c3773e8d08e5bf21785e6832803
assimp/5.1.6@#95ed2fe388b70810da00e6c96d1227a3
|
https://github.com/assimp/assimp/releases/tag/v5.4.0
No new formats or exporters were added in this release.