Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assimp: add v5.4.1 #23735

Merged
merged 7 commits into from
May 21, 2024
Merged

assimp: add v5.4.1 #23735

merged 7 commits into from
May 21, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Apr 23, 2024

https://github.com/assimp/assimp/releases/tag/v5.4.0

No new formats or exporters were added in this release.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit d05adc0
assimp/5.4.0@#2e500b9b6a6ee6fa518ef039da5e00f2
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_encoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
assimp/5.2.5@#00b00174c78834f0d70c837ff033d943
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_encoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
assimp/5.3.1@#d526496053e32e6fba656bb259a34035
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_encoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
assimp/5.2.2@#510da41e7ae1bd4ac1608fa26b51cc61
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_encoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
assimp/5.1.6@#1c4559a6f6cebedcb1dea81c292b7475
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_encoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@AbrilRBS
Copy link
Member

Should we ensure we don't get bitten by changes like assimp/assimp@v5.3.1...v5.4.0#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR140 in the future? ASSIMP_BUILD_ZLIB changed value but we don't set it in the generate method

@AbrilRBS AbrilRBS self-assigned this Apr 29, 2024
@valgur
Copy link
Contributor Author

valgur commented Apr 30, 2024

@RubenRBS Thanks for catching that. I added explicit handling of all relevant CMake options.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 1a9db0b
assimp/5.4.0@#1d2a20647ea14a07e510d8bd6767f737
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_encoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
assimp/5.3.1@#e91fc38f245a2ca02360595b5a00d42d
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_encoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
assimp/5.2.5@#5c5957a06229b332fc6b45639c61f51e
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_encoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
assimp/5.2.2@#5623ae58998e94a137e333047b3426f1
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_encoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
assimp/5.1.6@#23eecdd5674d467f944ce6af57ece733
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_encoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@sunbubble
Copy link
Contributor

https://github.com/assimp/assimp/releases/tag/v5.4.1

5.4.1 has just been released and addresses some Draco relating issues. Could it be related to the warnings emitted above?

@valgur valgur changed the title assimp: add v5.4.0 assimp: add v5.4.1 May 13, 2024
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 2cf3a45
assimp/5.4.1@#3bb2349246221841ad1e1ecb33c67cd5
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_encoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@sunbubble
Copy link
Contributor

@valgur thanks for bumping this so fast. Out of interest, do you know whether the warnings in the build is what's holding up the merging of this PR? Or is just the queue taking its time?

@valgur
Copy link
Contributor Author

valgur commented May 14, 2024

@sunbubble The queue of open PRs is simply very long (https://github.com/ericLemanissier/conan-center-index-pending-review/issues/3), although simple PRs like this one usually get reviewed faster.
I think the Conan devs are currently focusing on a major overhaul of the CCI CI system and Conan itself, so reviews can be somewhat slow.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @valgur :)
Minor question, otherwise looks good

recipes/assimp/5.x/conanfile.py Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 83c15ac
assimp/5.4.1@#0246f50c320eb797a5ae6aaa5eeda622
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@valgur valgur requested a review from AbrilRBS May 15, 2024 05:03
@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

I'm seeing some assimp/5.4.1: WARN: replace_in_file didn't find pattern '-fPIC' in '/Users/jenkins/workspace/prod-v2/bsr/38132/eabea/p/b/assimcb1569f627615/b/src/code/CMakeLists.txt' file. in https://c3i.jfrog.io/c3i/misc-v2/logs/pr/23735/3-macos-m1-clang/assimp/5.4.1//76e545471fe165ddd092b4cbb0361627c0f28db3-build.txt but it seems it's still there! https://github.com/assimp/assimp/blob/942518a4ff148ec10c62c425825c8186eec7fc65/CMakeLists.txt#L311

Are we thus not patching things properly?

@valgur
Copy link
Contributor Author

valgur commented May 17, 2024

@RubenRBS The logic was correct, but I cleaned up the patching to avoid the use of strict=False nevertheless.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (85cfebf2304299f3c3efa50450ae9cbd5ea7c8c9):

  • assimp/5.4.1:
    All packages built successfully! (All logs)

  • assimp/5.3.1:
    All packages built successfully! (All logs)

  • assimp/5.2.5:
    All packages built successfully! (All logs)

  • assimp/5.1.6:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (85cfebf2304299f3c3efa50450ae9cbd5ea7c8c9):

  • assimp/5.4.1:
    All packages built successfully! (All logs)

  • assimp/5.3.1:
    All packages built successfully! (All logs)

  • assimp/5.2.5:
    All packages built successfully! (All logs)

  • assimp/5.1.6:
    All packages built successfully! (All logs)

Copy link
Contributor

Hooks produced the following warnings for commit 85cfebf
assimp/5.4.1@#669250f69a5b55c5a7a6eb9b7183bffd
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_encoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
assimp/5.3.1@#0835bb213b5fe846fa5f3b325f9bde46
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_encoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
assimp/5.2.5@#e4f72c3773e8d08e5bf21785e6832803
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_encoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
assimp/5.1.6@#95ed2fe388b70810da00e6c96d1227a3
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_encoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/draco/src/draco/compression/attributes/prediction_schemes/prediction_scheme_normal_octahedron_canonicalized_decoding_transform.h' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@conan-center-bot conan-center-bot merged commit e1a7600 into conan-io:master May 21, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants