-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost: bump deps #23653
boost: bump deps #23653
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/boost//'. 👋 @grafikrobot @Hopobcn @jwillikers @paulharris you might be interested. 😉 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Ping in case this fell through the cracks :) @RubenRBS |
@robomics Sorry the delay. We are avoiding bump dependencies at first sight as they could result in version conflicts. Boost is not only well used in CCI, but its dependencies are also used in many other recipes. Do you need this bump dependencies to fix a conflict, or you are trying to use the latest version only of those libraries? We are also working on trying to use version ranges for more projects. I'm taking a look if we can use zstd as well, so it could help to avoid conflicts in the future. |
recipes/boost/all/conanfile.py
Outdated
@@ -651,14 +651,14 @@ def requirements(self): | |||
if self._with_bzip2: | |||
self.requires("bzip2/1.0.8") | |||
if self._with_lzma: | |||
self.requires("xz_utils/5.4.4") | |||
self.requires("xz_utils/5.4.5") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for using 5.4.5
, which is the version used in nearly all other recipes except ones still awaiting migration to Conan 2.0.
Thanks for looking into this @uilianries! When I submitted this PR I was declaring dependencies using Let me know if i should push a commit to use version ranges for zstd and v5.4.5 for xz_utils, as suggested by valgur. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm blocking this PR for now due conflicts that will result after merging it.
The Boost library not only uses several dependencies, but also is used by many other packages in CCI, which means, bump dependencies is really fragile here. Unless it has a strong motivation for bumping those dependencies, like security flaw, fixing a proved conflict or official bug, I would prefer focusing updating common dependencies first, then, updating Boost only as last step.
This is unfortunately for your case, as you still need to use override in your conanfile.py.
Packages that may break:
-
Arrow:
Usesboost/1.84.0
andzstd/1.5.5
. With Boost usingzstd/1.5.6
(even with version range), it will result in conflict. -
Pdal (Outdated):
Usesboost/1.78.0
,xz_utils/5.2.5
andzstd/1.5.2
. -
Folly
Usesboost/1.78.0
,xz_utils/5.2.5
andzstd/1.5.2
. Folly has other PRs like folly: migrate to Conan v2 #21109 that should fix that conflict. -
innoextract
Usesboost/1.80.0
,xz_utils/5.2.5
. -
opene57
Usesboost/1.84.0
,icu/74.1
.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robomics Sorry for blocking the PR, it was intended to avoid merging it by mistake.
After talking to Conan team, the number of affected packages is small and we can open separated PRs to fix as well. At time, Boost is largely used in CCI and should continue working with your change.
I updated your PR with few changes:
- Use version range for zstd. Still, it's the first recipe using it.
- Add version range for xz_utils. Not documented yet, but looks very stable and compatible.
Hope these changes fix your current conflicts.
Awesome! Many thanks! |
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 4 (
|
Hooks produced the following warnings for commit 396d8ddboost/1.85.0@#939ac8280c3683bfacd3bb6d89803d9b
boost/1.84.0@#354531e48fccef4d5afe10384bef9bf1
boost/1.81.0@#344fa45b45f8016e82b2ab8babd34381
boost/1.78.0@#7b4c7d804bf37e1529f853e44fc56833
boost/1.83.0@#9e26bb95bab2b013275b88d4e90f7310
boost/1.82.0@#de5761cd5ba5bbfc672be141192011bd
boost/1.76.0@#8c432b7944d1b32a0a30532f079d8a61
boost/1.79.0@#352f5f674f37d3b274ba3df333529bbc
boost/1.72.0@#6a2f9904e6ddf8e622879825b05b0e54
boost/1.77.0@#14887cdeff7788846ea210eb00d4fcfe
boost/1.80.0@#2e944a58d50f66835459a836929685f2
boost/1.74.0@#d45b0a7a71c039344ab0f3ab2b9fde04
boost/1.75.0@#19b91ca405843df32a6f1df5f5db869b
boost/1.71.0@#40d191b876173885dc106a395f14d2cf
boost/1.73.0@#abd7ec3f3e743e439c01089b2ff8b018
|
This PR has been automatically merged due to |
Specify library name and version: boost/all