Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moltenvk-1.2.2 package for xcode-15.3 onwards #23591

Closed
wants to merge 5 commits into from

Conversation

Twon
Copy link
Contributor

@Twon Twon commented Apr 17, 2024

Specify library name and version: moltenvk/1.2.2

I am submitting this issue as I have encountered this on my personal project and its is a blocker to supporting the latest Xcode version. The issue can be seen reproduced here: Twon/Morpheus#294

This change introduces the applied fix to the main repository as a patch: KhronosGroup/MoltenVK#2157

Fixes: #23590


@Twon Twon changed the title dev-twon-moltenvk-1.2.2-patch-for-xcode-15.3 Fix moltenvk-1.2.2 package for xcode-15.3 onwards Apr 17, 2024
@ghost
Copy link

ghost commented Apr 17, 2024

I detected other pull requests that are modifying moltenvk/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Apr 17, 2024
@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

Hi! Thanks a lot - I've now triggered the build of the missing binaries. I'll make sure to restart the PR once they are built and will ping you when so :)

@AbrilRBS AbrilRBS self-assigned this Apr 17, 2024
@conan-center-bot

This comment has been minimized.

Co-authored-by: Tony Wasserka <4840017+neobrain@users.noreply.github.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (0b8081a21b3ca5f41f15918f313bc28a9308faff):

  • moltenvk/1.2.2:
    All packages built successfully! (All logs)

  • moltenvk/1.2.1:
    All packages built successfully! (All logs)

  • moltenvk/1.2.0:
    All packages built successfully! (All logs)

  • moltenvk/1.1.10:
    All packages built successfully! (All logs)

  • moltenvk/1.1.11:
    All packages built successfully! (All logs)

  • moltenvk/1.1.8:
    All packages built successfully! (All logs)

  • moltenvk/1.1.9:
    All packages built successfully! (All logs)

  • moltenvk/1.1.5:
    All packages built successfully! (All logs)

  • moltenvk/1.1.4:
    All packages built successfully! (All logs)

  • moltenvk/1.1.6:
    All packages built successfully! (All logs)

  • moltenvk/1.1.1:
    All packages built successfully! (All logs)

  • moltenvk/1.1.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 5 (0b8081a21b3ca5f41f15918f313bc28a9308faff):

  • moltenvk/1.2.1:
    Didn't run or was cancelled before finishing

  • moltenvk/1.2.0:
    Didn't run or was cancelled before finishing

  • moltenvk/1.1.10:
    Didn't run or was cancelled before finishing

  • moltenvk/1.2.2:
    Didn't run or was cancelled before finishing

  • moltenvk/1.1.11:
    Didn't run or was cancelled before finishing

  • moltenvk/1.1.8:
    Didn't run or was cancelled before finishing

  • moltenvk/1.1.6:
    CI failed to create some packages (All logs)

    Logs for packageID 52401a77ab740d51a9535fdd95be6743584c43b3:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.cppstd=17
    compiler.libcxx=libc++
    compiler.version=13
    os=Macos
    [options]
    */*:shared=False
    
    [...]
    spirv-tools/2021.4: '8d2c2c058223c16efc6859aac91b78444b0b6b80': compiler.cppstd=20
    spirv-tools/2021.4: '712835afdc289b163906327a779146bfbf778bc3': compiler.cppstd=gnu20
    spirv-tools/2021.4: '543d834a3eeb5298b9a2b6c7889461b215a21a71': compiler.cppstd=23
    spirv-tools/2021.4: '48db5838ec797cf280d7b9933a3640c2c6904278': compiler.cppstd=gnu23
    glslang/11.7.0: Checking 9 compatible configurations
    glslang/11.7.0: Compatible configurations not found in cache, checking servers
    glslang/11.7.0: 'db62b19ab14f532bc04711eafac20fa6ef736094': compiler.cppstd=11
    glslang/11.7.0: 'c496b7af6f161a020b8c5b7e32cac2544f0ae06e': compiler.cppstd=gnu11
    glslang/11.7.0: '1314561cf6a7793d3a984088fd381eb1ac659bbe': compiler.cppstd=14
    glslang/11.7.0: '1152013322bff8420511006e126d2802c9d606e9': compiler.cppstd=gnu14
    glslang/11.7.0: '13aaab3b7806c3331e415818fc7bcdfeedf71913': compiler.cppstd=gnu17
    glslang/11.7.0: '0a64bb63354f0bfa26024fae51e9901662a345fa': compiler.cppstd=20
    glslang/11.7.0: 'c09e3010c268227b3f9f8bf7b6c9a053b7ae62d4': compiler.cppstd=gnu20
    glslang/11.7.0: '772de66554bd634eb145a2dfed3748c55c31ed31': compiler.cppstd=23
    glslang/11.7.0: '4ef82b09635c49889379e8a43ddebbd41cf88fff': compiler.cppstd=gnu23
    moltenvk/1.1.6: Forced build from source
    Requirements
        cereal/1.3.2#b94802e904e1129e7fdb46d9bff5321d:da39a3ee5e6b4b0d3255bfef95601890afd80709#0ebb9058692e29b6254aad3b967b53b8 - Download (conan-center)
        glslang/11.7.0#48f276cb78ef05fdbcac7d17a4760bae:223326f18b5e63de3e44730cf02b94aa7e19a900 - Missing
        moltenvk/1.1.6#b0ee808d63ed88697854df59a27078ce:52401a77ab740d51a9535fdd95be6743584c43b3 - Build
        spirv-cross/cci.20211113#cc8a1175bb0d6bfe3587cf8cb7465c70:a76eac86541126247cd64a3792ea809bad6046da#869247d1e03cc07390faaa7e08e3a2ae - Download (conan-center)
        spirv-tools/2021.4#f320c0462dfb5fa5c1d0db1c59ffc2ee:453414f08bd704b57fc3b4c0e41adc5f850c5583 - Missing
        vulkan-headers/1.2.198.0#0cf1bf099a5fb7ac5660415972d26f69:da39a3ee5e6b4b0d3255bfef95601890afd80709#d846524a55d978eacb999d6096cd4cce - Download (conan-center)
    Skipped binaries
        spirv-headers/1.2.198.0
    ERROR: Missing binary: glslang/11.7.0:223326f18b5e63de3e44730cf02b94aa7e19a900
    ERROR: Missing binary: spirv-tools/2021.4:453414f08bd704b57fc3b4c0e41adc5f850c5583
    
    spirv-tools/2021.4: WARN: Can't find a 'spirv-tools/2021.4' package binary '453414f08bd704b57fc3b4c0e41adc5f850c5583' for the configuration:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.cppstd=17
    compiler.libcxx=libc++
    compiler.version=13
    os=Macos
    [options]
    build_executables=True
    fPIC=True
    shared=False
    [requires]
    spirv-headers/1.2.198.0#be23dbe09db97c81d97954672fa28f94:da39a3ee5e6b4b0d3255bfef95601890afd80709
    
    ERROR: Missing prebuilt package for 'glslang/11.7.0', 'spirv-tools/2021.4'. You can try:
        - List all available packages using 'conan list spirv-tools/2021.4:* -r=remote'
        - Explain missing binaries: replace 'conan install ...' with 'conan graph explain ...'
        - Try to build locally from sources using the '--build=glslang/11.7.0 --build=spirv-tools/2021.4' argument
    
    More Info at 'https://docs.conan.io/2/knowledge/faq.html#error-missing-prebuilt-package'
    
  • moltenvk/1.1.4:
    Didn't run or was cancelled before finishing

  • moltenvk/1.1.5:
    Didn't run or was cancelled before finishing

  • moltenvk/1.1.9:
    Didn't run or was cancelled before finishing

  • moltenvk/1.1.1:
    Didn't run or was cancelled before finishing

  • moltenvk/1.1.0:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@Twon Twon requested a review from neobrain April 28, 2024 13:56
@Twon
Copy link
Contributor Author

Twon commented May 1, 2024

Hi! Thanks a lot - I've now triggered the build of the missing binaries. I'll make sure to restart the PR once they are built and will ping you when so :)

Hi @RubenRBS, it looks like this is still failing due to missing package dependencies. Is this something which given enough time will resolve itself (i.e. the missing package will be built) or is there some action required on my part to address this in the changes?

@Twon Twon deleted the branch conan-io:master May 3, 2024 09:28
@Twon Twon closed this May 3, 2024
@Twon Twon deleted the master branch May 3, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Failed Missing dependencies Build failed due missing dependencies in Conan Center
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] MoltenVK/1.2.2: Fails to build under Xcode 15.3 onwards
4 participants