-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glib: add v2.80.0 #23559
glib: add v2.80.0 #23559
Conversation
This comment has been minimized.
This comment has been minimized.
it introduces a cyclic dependency with gobject-introspection
This comment has been minimized.
This comment has been minimized.
because pkg-config is not installed on macos runners
The build is now finished. You can take a look at the results here |
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 4 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@memsharded @uilianries I think this PR is implementing the solution you had in mind in conan-io/conan-docker-tools#554 (comment)
Can we get a review in order to finally make progress ?
Closing as superseded by #24591. Most of the changes here were related to the Python 3.12 issues. |
Continues from #23193. Related to #23557 and conan-io/conan-docker-tools#554 (comment)
Addsself.tool_requires("cpython/3.12.2")
and installs a pinned version ofpackaging
from PyPI locally into the build folder.The published package artifacts on PyPI are immutable, so the pinned version will provide reproducible builds and is reflected in the package hash via the conanfile.py contents, if I'm not mistaken.I think this approach is a simple and scalable way to deal with build-scope Python dependencies on CCI in general.Edit: @ericLemanissier pointed out to me that the
packaging
dependency is a transitive build dep. Since we decided not to package it separately, the only option left was to vendor the two required files. Which I did.