-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mingw-builds: added 13.2.0 #23481
mingw-builds: added 13.2.0 #23481
Conversation
bf4a47b
to
5b0d6e1
Compare
Zlib builds fine:
|
This comment has been minimized.
This comment has been minimized.
3659d45
to
81c8fac
Compare
I don't know why the pipeline is failing 🤔any chance to read the logs? |
This comment has been minimized.
This comment has been minimized.
options = { | ||
"threads": ["posix", "win32", "mcf"], | ||
"exception": ["seh", "sjlj"], | ||
"runtime": ["msvcrt", "ucrt"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were no runtime
before, are we sure for other previous versions the ucrt
was the default one? I am not sure about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a null
value should be introduced for older versions, so it doesn't affect the package_id
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So with 12.0v10r2 it was introduced the ucrt
runtime. Before that msvcrt
was the only choice. https://github.com/niXman/mingw-builds-binaries/releases is possible to see all the changelog releases.
How do you handle situation where the default value of an option changes in base of the version of the package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a null value should be introduced for older versions, so it doesn't affect the package_id?
Can you elaborate a bit more? I am not very familiar with how package_id
is computed. But yes, I do agree that for older versions should be unchanged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if it's the right approach but on the validate()
method I remove the runtime options for the versions <= 12.2.0. This way the package_id
shouldn't change. How can I make a quick check to validate this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately the package_id
are different also removing the runtime
:
Using conan list mingw-builds/12.2.0:* -r conancenter
:
conancenter
mingw-builds
mingw-builds/12.2.0
revisions
6d4f9fa696c4097c55762e2f481a2355 (2023-07-06 11:14:43 UTC)
packages
f4943bfd33cc2961ebbb1d81bf8b090153522e1f
info
settings
arch: x86_64
os: Windows
options
exception: seh
threads: posix
While my local package is:
local
mingw-builds
mingw-builds/12.2.0
revisions
e24bc714576c31c8f083b580dae5257b (2024-04-17 14:31:06 UTC)
packages
f82b765f5ccc390bb8d409c50689a5c5ab3eb642
info
settings
arch: x86_64
os: Windows
options
exception: seh
runtime: ucrt
threads: posix
Any idea on how to fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok it was as simple as doing this during the configure()
method. Now the package_id are identical for the previous releases:
$ conan list mingw-builds/12.2.0:* -r local
local
mingw-builds
mingw-builds/12.2.0
revisions
bf2318e4f907e60965dfcd7c85575f43 (2024-04-17 15:11:11 UTC)
packages
f4943bfd33cc2961ebbb1d81bf8b090153522e1f
info
settings
arch: x86_64
os: Windows
options
exception: seh
threads: posix
$ conan list mingw-builds/12.2.0:* -r conancenter
conancenter
mingw-builds
mingw-builds/12.2.0
revisions
6d4f9fa696c4097c55762e2f481a2355 (2023-07-06 11:14:43 UTC)
packages
f4943bfd33cc2961ebbb1d81bf8b090153522e1f
info
settings
arch: x86_64
os: Windows
options
exception: seh
threads: posix
$ conan list mingw-builds/13.2.0:* -r local
local
mingw-builds
mingw-builds/13.2.0
revisions
e24bc714576c31c8f083b580dae5257b (2024-04-17 15:11:13 UTC)
packages
f82b765f5ccc390bb8d409c50689a5c5ab3eb642
info
settings
arch: x86_64
os: Windows
options
exception: seh
runtime: ucrt
threads: posix
Note that StrawberryPerl has a similar discussion: StrawberryPerl/Perl-Dist-Strawberry#104 |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 0d6d4e5mingw-builds/12.1.0@#492639d9fe46d63470769e23bb65ec5d
mingw-builds/13.2.0@#ab22f49d3346136be2b91fdeaf2f39c9
mingw-builds/12.2.0@#fba37d1c312ec43c3389b97223d6d0a9
mingw-builds/11.2.0@#66f80ca98971fd2e64d2f2dff0472824
mingw-builds/8.1@#087e67d43be91786b30458f21d52d18d
|
Also the threading model could be changed to use mcf instead of posix, it seemed much more performant and suitable for GCC. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Any opinion about this PR? |
Conan v1 pipeline ✔️All green in build 18 (
Conan v2 pipeline ✔️
All green in build 18 (
|
Hi @elvisdukaj - we are still in the process of reviewing this. Please avoid updating the branch without making changes to the recipe - it triggers the CI process again for the new commit, using compute resources unnecessarily. |
Specify library name and version: mingw-builds/13.2.0
I added MinGW 13.2.0 version. Note that this version adds a new runtime UCRT runtime options that I set as default as suggested in the MinGW documentation
On the other hand:
Maybe a better option could use by default UCRT with Windows 10+ and MSVCRT otherwise, is any option to check the version of Windows?