Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openal-soft: restore dangling patch #23353

Merged
merged 1 commit into from
Apr 4, 2024
Merged

openal-soft: restore dangling patch #23353

merged 1 commit into from
Apr 4, 2024

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented Apr 3, 2024 •
edited
Loading

it got wrongly removed in a merge commit in #21221

Specify library name and version: openal-soft/*

@ericLemanissier
openal-soft: restore dangling patch
b85df45 
it got wrongly removed in a merge commit in conan-io#21221
@conan-center-bot

This comment has been minimized.

Sign in to view
valgur
valgur approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@prince-chrismc prince-chrismc mentioned this pull request Apr 3, 2024
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries
Copy link
Member

Just restart the failed build. There was a networking error in the middle of the execution.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (b85df45f82eb0111ab2fb62695ee7365d259130f):

  • openal-soft/1.22.2:
    All packages built successfully! (All logs)

  • openal-soft/1.23.1:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (b85df45f82eb0111ab2fb62695ee7365d259130f):

  • openal-soft/1.23.1:
    All packages built successfully! (All logs)

  • openal-soft/1.22.2:
    All packages built successfully! (All logs)

@AbrilRBS AbrilRBS self-assigned this Apr 4, 2024
AbrilRBS
AbrilRBS approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@conan-center-bot conan-center-bot merged commit 77ed780 into conan-io:master Apr 4, 2024
19 checks passed
@ericLemanissier ericLemanissier deleted the openal-soft branch April 4, 2024 08:51
yhsng pushed a commit to yhsng/conan-center-index that referenced this pull request Apr 12, 2024
@ericLemanissier
(conan-io#23353) openal-soft: restore dangling patch
9cf39bb 
it got wrongly removed in a merge commit in conan-io#21221
ericLemanissier added a commit to ericLemanissier/conan-center-index that referenced this pull request Apr 16, 2024
@ericLemanissier
(conan-io#23353) openal-soft: restore dangling patch
40453ce 
it got wrongly removed in a merge commit in conan-io#21221
@ericLemanissier ericLemanissier mentioned this pull request Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceIm SpaceIm SpaceIm approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@valgur valgur valgur approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ericLemanissier @conan-center-bot @uilianries @valgur @AbrilRBS @SpaceIm