Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcvd: add toon dependency #23336

Merged
merged 3 commits into from
Jul 4, 2024
Merged

libcvd: add toon dependency #23336

merged 3 commits into from
Jul 4, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Apr 2, 2024 •
edited
Loading

TooN is used by a large chunk of the library, so make it a required dependency.

@prince-chrismc prince-chrismc mentioned this pull request Apr 2, 2024
Open
@conan-center-bot conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Apr 2, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
Copy link
Contributor Author

valgur commented Apr 2, 2024

@uilianries Can you help with the missing toon binary, please?

@conan-center-bot conan-center-bot removed Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Apr 21, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (909175ce7f0dc796bef134b24b7acbbe24aac354):

  • libcvd/2.5.1:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (909175ce7f0dc796bef134b24b7acbbe24aac354):

  • libcvd/2.5.1:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot requested a review from danimtb July 3, 2024 11:38
AbrilRBS
AbrilRBS approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AbrilRBS AbrilRBS self-assigned this Jul 3, 2024
perseoGI
perseoGI approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 67a82da into conan-io:master Jul 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perseoGI perseoGI perseoGI approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@danimtb danimtb Awaiting requested review from danimtb

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@valgur @conan-center-bot @AbrilRBS @perseoGI