-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openssl: make things a bit more generic #23304
Conversation
FYI @Croydon |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@RubenRBS any progress here? |
@SpaceIm @RubenRBS could you approve/merge this, please? Much appreciated! |
The change here is harmless, but since the purpose is hidden and since it differs from other recipes, it might be very well, that this gets broken regularly one way or another 🤔 |
I hear you @Croydon, but I'm willing to take the risk.. 😉 |
This comment has been minimized.
This comment has been minimized.
This removes some hardcoded names and allows for the package to be "renamed" more easily... For example if one wanted to create a distinct `openssl-fips` package so as to use it in conjunction with the standard `openssl` package without any collision. See conan-io#22796 for more context
This comment has been minimized.
This comment has been minimized.
@RubenRBS 🙏🏻. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gegles, thanks for your contribution and for providing insights in #23304.
based on the details you have provided in the issue #22796 I think we can actually implement something along the lines of your initial proposal (a requires on an earlier version of itself) - which would be a lot simpler (a few lines, if I'm not mistaken), and would require no further changes - in particular, no two different recipes
If your team requires changes in Conan Center that we may not be able to merge or need further review, please consider the guidance and advice in: https://docs.conan.io/2/devops/using_conancenter.html#control-and-customization
@jcar87, that would be amazing, thanks! |
@jcar87 @RubenRBS, I think it would still make the code cleaner and less "hardcoded" to merge this in, despite the great & elegant alternaitve solution currently worked on in parallel, but if not, I am also fine closing this PR. LMK. Thx! |
@jcar87 @RubenRBS, I think it would still make the code cleaner and less "hardcoded" to merge this in, despite the great & elegant alternaitve solution currently worked on in parallel, but if not, I am also fine closing this PR. LMK. Thx! |
Conan v1 pipeline ✔️All green in build 7 (
Conan v2 pipeline ✔️
All green in build 7 (
|
Closing due to lack of interest/consensus.... |
This removes some hardcoded names and allows for the package to be "renamed" more easily...
For example if one wanted to create a distinct
openssl-fips
package so as to use it in conjunction with the standardopenssl
package without any collision.See #22796 for more context
Specify library name and version: openssl/3.x.x