giflib: add version 5.2.2 #23282
giflib: add version 5.2.2 #23282
Conversation
|
I detected other pull requests that are modifying giflib/5.2.x recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
there's a data export that can't be exported using CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@mayeut Thank you for your PR! Could you please point exactly where does the patch https://github.com/conan-io/conan-center-index/pull/23282/files#diff-8ff1b4569ab947aba99fa9aad7dbe500095cf76950b5903eb491ba1356a78fe0 comes from? Do you have any reference from the upstream? I don't find anything related in the upstream code: https://sourceforge.net/p/giflib/code/ci/master/tree/gif_font.c |
|
I just sent a merge request to the upstream supporting CMake: https://sourceforge.net/p/giflib/code/merge-requests/15/ Let's see if we can drop most of CMake stuff from here. |
There was a problem hiding this comment.
The giflib has workarounds already, this one is simple enough and accepted in other parts.
I sent a PR to the upstream asking for CMake support here: https://sourceforge.net/p/giflib/code/merge-requests/15/
In case positive, in the future we can send a new PR with DLL support too.
* giflib: add version 5.2.2 * remove export patch & use CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS * Use strtok_s instead of strtok_r with MSVC * split patch * Use patch for symbol export there's a data export that can't be exported using CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS
* giflib: add version 5.2.2 * remove export patch & use CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS * Use strtok_s instead of strtok_r with MSVC * split patch * Use patch for symbol export there's a data export that can't be exported using CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS
Specify library name and version: giflib/5.2.2
giflib 5.2.2 comes with fixes for CVE-2023-48161, CVE-2022-28506