-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
premake: add 5.0.0-beta2, unvendor deps, add support for cross-building #23223
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied all patches to the non-bootstrapped build system based on the original premake build files instead of the bootstrap Makefiles and vcxprojects, which keeps the recipe much simpler.
I don't get it. What does the mean?
Is the way to build Premake that you choose official supported on all configurations?
Although a pre-release, v5.0.0 is being actively used by the yojimbo recipe, for example, so it's worth an update, imo.
This is really no criteria for a project that gets actively developed but is so afraid of stable releases, that their last official stable release is from 2010... see e.g. premake/premake-core#178
So, in the case of Premake it is completely okay to have alpha and beta releases added.
See https://github.com/premake/premake-core/blob/master/BUILD.txt#L27 The packaged source archives include build scripts for each different platform (Linux and macOS Makefiles, VS projects, etc) that have been "bootstrapped" from the premake5.lua Premake build script. Since this PR rewrites the build scripts to rely on dependencies from Conan instead of the vendored versions, it's much more efficient to modify the input
Yes. It's identical to what the project itself does for the source archives. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 12 (
Conan v2 pipeline ✔️
All green in build 12 ( |
Although a pre-release, v5.0.0 is being actively used by the
yojimbo
recipe, for example, so it's worth an update, imo. The existing version did not support cross-building.Also unvendored
libcurl
,mbedtls
,libzip
andzlib
to ensure that the most up-to-date versions of these are used.Applied all patches to the non-bootstrapped build system based on the original premake build files instead of the pre-generated Makefiles and vcxprojects. This avoids the need to patch 13 different build configs.