Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freetype: use libpng version range #23004

Conversation

jcar87
Copy link
Contributor

@jcar87 jcar87 commented Mar 6, 2024

freetype: all versions

Use a version range for libpng in requirements. This avoids version conflicts when libpng is consumed transitively, since most of the repo is still in 1.6.40 rather than 1.6.42.

It's a rather artificial conflict when it happens - libpng is backwards compatible at the API level, and Conan 2 defaults (the minor version component is encoded in the consumers) will ensure binary compatibility of produced binaries (e.g. libpng/1.6.x may not necessarily be binary compatible with libpng/1.5.x, but .patch versions of the same minor will be). libpng changes the library filename and soname when jumping to new minors. The default documented behaviour https://docs.conan.io/2.0/reference/conanfile/attributes.html#package-id-embed-non-embed-unknown-mode should ensure that new binary packages are generated in that case if libpng is updated.

@uilianries uilianries self-requested a review March 6, 2024 14:03
@jcar87 jcar87 marked this pull request as draft March 6, 2024 14:10
@ghost
Copy link

ghost commented Mar 6, 2024

I detected other pull requests that are modifying freetype/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (1be2a5eb89cfad42fbed3ea15a4daa8d020c6f6b):

  • freetype/2.13.0:
    All packages built successfully! (All logs)

  • freetype/2.11.1:
    All packages built successfully! (All logs)

  • freetype/2.12.1:
    All packages built successfully! (All logs)

  • freetype/2.13.2:
    All packages built successfully! (All logs)

  • freetype/2.10.4:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (1be2a5eb89cfad42fbed3ea15a4daa8d020c6f6b):

  • freetype/2.10.4:
    All packages built successfully! (All logs)

  • freetype/2.12.1:
    All packages built successfully! (All logs)

  • freetype/2.13.0:
    All packages built successfully! (All logs)

  • freetype/2.13.2:
    All packages built successfully! (All logs)

  • freetype/2.11.1:
    All packages built successfully! (All logs)

@jcar87 jcar87 marked this pull request as ready for review March 6, 2024 14:54
@conan-center-bot conan-center-bot merged commit 92bca12 into conan-io:master Mar 6, 2024
34 checks passed
@jcar87 jcar87 deleted the lcc/hotfix/freetype-libpng-use-version-range branch March 6, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants