Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dispenso: Add new recipe #22876

Merged
merged 11 commits into from
May 14, 2024
Merged

dispenso: Add new recipe #22876

merged 11 commits into from
May 14, 2024

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Feb 24, 2024 •
edited
Loading

Specify library name and version: dispenso/1.3.0

@AbrilRBS AbrilRBS self-assigned this Feb 24, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit 1369f39
dispenso/1.3.0@#9b8495def33c41cf746144b89c931b37 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdispenso.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

Sign in to view
@AbrilRBS AbrilRBS marked this pull request as ready for review April 29, 2024 22:19
@AbrilRBS AbrilRBS mentioned this pull request Apr 29, 2024
Closed
1 task
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc prince-chrismc mentioned this pull request Apr 29, 2024
Open
uilianries
uilianries previously approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I would suggest only dropping cmake_find_package and we are good to go.

recipes/dispenso/all/conanfile.py Outdated Show resolved Hide resolved
recipes/dispenso/all/patches/1.3.0-001-unvendorize-concurrentqueue.patch Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a personal note to send a PR to the upstream, adding an option to consume as external library :)

@AbrilRBS @uilianries
Update recipes/dispenso/all/conanfile.py
33aa262 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
uilianries
uilianries approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (33aa262cf057abcccb472f8f030ca8b53580cd1f):

  • dispenso/1.3.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (33aa262cf057abcccb472f8f030ca8b53580cd1f):

  • dispenso/1.3.0:
    All packages built successfully! (All logs)

@uilianries uilianries assigned uilianries and unassigned uilianries May 10, 2024
@AbrilRBS AbrilRBS assigned uilianries and unassigned AbrilRBS May 14, 2024
@conan-center-bot conan-center-bot merged commit 99c3536 into conan-io:master May 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@uilianries uilianries uilianries approved these changes

Assignees

@uilianries uilianries

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AbrilRBS @conan-center-bot @uilianries @jwillikers