-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glm: add version 1.0.0 #22657
glm: add version 1.0.0 #22657
Conversation
This comment has been minimized.
This comment has been minimized.
I decided in the end to remove the older versions to simplify the conanfile, as i also believe that the cci versions are not necessary anymore that there's an official release. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@StellaSmith Please, don't forget to update the |
😅 i did this at like 2 am so i forgot |
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 4 ( |
Hi everyone! |
@StellaSmith Could you replace the v1.0.0 in this PR with v1.0.1, please. @RubenRBS a review would be welcome. It's a pretty small PR. |
Hi @valgur, |
@TheHugeManatee Yes, that should be perfectly fine since they have signed the CLA. Feel free to open a new PR based off these commits. |
Thanks for the quick feedback! I created a new PR here: #23742 . I guess this one can be closed then. |
I'm closing this PR in favor of this one already merged #23742 Thanks! |
g-truc/glm#1226
The released archive has a bit of a different structure than previous releases, so i had to add some conditionals for v1.0.0.
I'm wondering if I should also delete the cci.yyyymmdd versions and/or create a different subfolder for this release.