Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wolfssl: add with_curl option #22486

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented Jan 22, 2024

Specify library name and version: wolfssl/*

I met compilation errors on executing conan install --requires=libcurl/8.5.0@ --build=missing -o libcurl/\*:with_ssl=wolfssl.

libcu091943b01efd5/b/src/lib/http_aws_sigv4.c: In function 'sha256_to_hex':
  CC       libcurl_la-if2ip.lo
libcu091943b01efd5/b/src/lib/http_aws_sigv4.c:67:23: error: 'SHA256_DIGEST_LENGTH' undeclared (first use in this function); did you mean 'SHA256_HEX_LENGTH'?
   67 |   Curl_hexencode(sha, SHA256_DIGEST_LENGTH,
      |                       ^~~~~~~~~~~~~~~~~~~~
      |                       SHA256_HEX_LENGTH
libcu091943b01efd5/b/src/lib/http_aws_sigv4.c:67:23: note: each undeclared identifier is reported only once for each function it appears in
libcu091943b01efd5/b/src/lib/http_aws_sigv4.c: In function 'calc_s3_payload_hash':
libcu091943b01efd5/b/src/lib/http_aws_sigv4.c:63:32: error: 'SHA256_DIGEST_LENGTH' undeclared (first use in this function); did you mean 'SHA256_HEX_LENGTH'?
   63 | #define SHA256_HEX_LENGTH (2 * SHA256_DIGEST_LENGTH + 1)
      |                                ^~~~~~~~~~~~~~~~~~~~
libcu091943b01efd5/b/src/lib/http_aws_sigv4.c:310:33: note: in expansion of macro 'SHA256_HEX_LENGTH'
  310 |                                 SHA256_HEX_LENGTH)
      |                                 ^~~~~~~~~~~~~~~~~
libcu091943b01efd5/b/src/lib/http_aws_sigv4.c:393:21: note: in expansion of macro 'CONTENT_SHA256_HDR_LEN'
  393 |   msnprintf(header, CONTENT_SHA256_HDR_LEN,
      |                     ^~~~~~~~~~~~~~~~~~~~~~
  CC       libcurl_la-imap.lo
libcu091943b01efd5/b/src/lib/http_aws_sigv4.c: In function 'Curl_output_aws_sigv4':
libcu091943b01efd5/b/src/lib/http_aws_sigv4.c:542:26: error: 'SHA256_DIGEST_LENGTH' undeclared (first use in this function); did you mean 'SHA256_HEX_LENGTH'?
  542 |   unsigned char sha_hash[SHA256_DIGEST_LENGTH];
      |                          ^~~~~~~~~~~~~~~~~~~~
      |                          SHA256_HEX_LENGTH

To solve it, I have to build wolfssl with --enable-curl arg which has been introduced since 5.2.0.
https://www.wolfssl.com/using-curl-with-wolfssl-and-tls-1-3/

This PR is adding the option to set --enable-curl.


@ghost
Copy link

ghost commented Jan 22, 2024

I detected other pull requests that are modifying wolfssl/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (a2da3edd73766861b88306fc7f5c41ed1b31f565):

  • wolfssl/4.8.1:
    All packages built successfully! (All logs)

  • wolfssl/5.6.4:
    All packages built successfully! (All logs)

  • wolfssl/5.6.6:
    All packages built successfully! (All logs)

  • wolfssl/5.6.3:
    All packages built successfully! (All logs)

  • wolfssl/4.7.1:
    All packages built successfully! (All logs)

  • wolfssl/5.4.0:
    All packages built successfully! (All logs)

  • wolfssl/5.5.1:
    All packages built successfully! (All logs)

  • wolfssl/5.3.0:
    All packages built successfully! (All logs)

  • wolfssl/5.1.1:
    All packages built successfully! (All logs)

  • wolfssl/5.2.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (a2da3edd73766861b88306fc7f5c41ed1b31f565):

  • wolfssl/4.8.1:
    All packages built successfully! (All logs)

  • wolfssl/5.6.6:
    All packages built successfully! (All logs)

  • wolfssl/5.6.4:
    All packages built successfully! (All logs)

  • wolfssl/5.5.1:
    All packages built successfully! (All logs)

  • wolfssl/5.1.1:
    All packages built successfully! (All logs)

  • wolfssl/5.2.0:
    All packages built successfully! (All logs)

  • wolfssl/5.4.0:
    All packages built successfully! (All logs)

  • wolfssl/4.7.1:
    All packages built successfully! (All logs)

  • wolfssl/5.3.0:
    All packages built successfully! (All logs)

  • wolfssl/5.6.3:
    All packages built successfully! (All logs)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the detailed PR message :)

@AbrilRBS AbrilRBS self-assigned this Jan 22, 2024
@conan-center-bot conan-center-bot merged commit cee049b into conan-io:master Jan 22, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants