Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wayland: fix cross-building tests to use correct method #22167

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

kuroneko
Copy link
Contributor

@kuroneko kuroneko commented Jan 5, 2024

Specify library name and version: waylland/1.22.0


* Fix conan-io#22166: switch from using cross_building to using can_run so the
  conf option that explicitly says we must (or must not) cross build is
  respected correctly.
Copy link
Contributor

github-actions bot commented Jan 5, 2024

🤖 Beep Boop! This pull request is making changes to 'recipes/wayland//'.

👋 @jwillikers you might be interested. 😉

@ghost
Copy link

ghost commented Jan 5, 2024

I detected other pull requests that are modifying wayland/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@jwillikers jwillikers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AbrilRBS AbrilRBS self-assigned this Jan 6, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (65f749aff180e0d18618316990ce77336b02ef35):

  • wayland/1.22.0:
    All packages built successfully! (All logs)

  • wayland/1.21.0:
    All packages built successfully! (All logs)

  • wayland/1.19.0:
    All packages built successfully! (All logs)

  • wayland/1.20.0:
    All packages built successfully! (All logs)

  • wayland/1.18.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (65f749aff180e0d18618316990ce77336b02ef35):

  • wayland/1.22.0:
    All packages built successfully! (All logs)

  • wayland/1.21.0:
    All packages built successfully! (All logs)

  • wayland/1.20.0:
    All packages built successfully! (All logs)

  • wayland/1.19.0:
    All packages built successfully! (All logs)

  • wayland/1.18.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 89eb693 into conan-io:master Jan 6, 2024
33 checks passed
@SpaceIm
Copy link
Contributor

SpaceIm commented Jan 6, 2024

Fix #22166: switch from using cross_building to using can_run so the conf option that explicitly says we must (or must not) cross build is respected correctly.

Just one comment: tools.build.cross_building:can_run doesn't express whether we cross-build or not. It can just tell to conan that executables cross-compiled for host can be executed on build machine.

@kuroneko
Copy link
Contributor Author

kuroneko commented Jan 7, 2024

Fix #22166: switch from using cross_building to using can_run so the conf option that explicitly says we must (or must not) cross build is respected correctly.

Just one comment: tools.build.cross_building:can_run doesn't express whether we cross-build or not. It can just tell to conan that executables cross-compiled for host can be executed on build machine.

From the meson perspective, it should be doing exactly that (See conan-io/conan#11035 for why can_run got introduced).

If the outputs run natively on the platform (transparent emulation or not), then you don't need to cross-build.

If the outputs can't run (without magic) despite the rest matching (such as caused by ABI mismatch), then you are cross-building.

So whilst I appreciate your niggle to the letter of the how the variable is described, the reality is that is meant to provide an override for cross building decisions where the automated approach decides incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] wayland/1.22.0: conanfile uses wrong test for cross building.
5 participants