-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wayland: fix cross-building tests to use correct method #22167
wayland: fix cross-building tests to use correct method #22167
Conversation
* Fix conan-io#22166: switch from using cross_building to using can_run so the conf option that explicitly says we must (or must not) cross build is respected correctly.
🤖 Beep Boop! This pull request is making changes to 'recipes/wayland//'. 👋 @jwillikers you might be interested. 😉 |
I detected other pull requests that are modifying wayland/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 ( |
Just one comment: |
From the meson perspective, it should be doing exactly that (See conan-io/conan#11035 for why can_run got introduced). If the outputs run natively on the platform (transparent emulation or not), then you don't need to cross-build. If the outputs can't run (without magic) despite the rest matching (such as caused by ABI mismatch), then you are cross-building. So whilst I appreciate your niggle to the letter of the how the variable is described, the reality is that is meant to provide an override for cross building decisions where the automated approach decides incorrectly. |
Specify library name and version: waylland/1.22.0