dcmtk: bump deps #21985

mayeut · 2023-12-27T14:00:04Z

Specify library name and version: dcmtk/all

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

Requires rosetta & `tools.build.cross_building:can_run=True`

mayeut · 2023-12-28T11:02:46Z

recipes/dcmtk/all/conanfile.py

+        if hasattr(self, "settings_build") and cross_building(self) and \
+           self.settings.os == "Macos" and self.settings.arch == "x86_64" and not can_run(self):
+            raise ConanInvalidConfiguration("Cross building to macOS x86_64 is only supported from macOS arm64 using rosetta with 'tools.build.cross_building:can_run=True'")


With the new macOS builders in CI using an arm64 build profile to build for x86_64 host, this recipe will now raise a ConanInvalidConfiguration exception.

Will the config be updated with tools.build.cross_building:can_run=True ?
If not, is there a simple workaround recommended ?

@uilianries @danimtb Tagging you as you were the most visibly involved with the M2 upgrade.

Can the M2 machines run both armv8 and x86_64 executables? And even if they can run both, should we still probably try to use the armv8 versions of the executables?

And even if they can run both, should we still probably try to use the armv8 versions of the executables?

In this specific instance, there's no armv8 version of the executable as it only there to allow some try_run calls in the CMake file.
Having tools.build.cross_building:can_run=True would also mean that tests could run entirely which is not the case anymore for macOS x86_64 builds.

I could add a specific _can_run property to the recipe in order not to require tools.build.cross_building:can_run=True if rosetta is available.

Can the M2 machines run both armv8 and x86_64 executables? And even if they can run both, should we still probably try to use the armv8 versions of the executables?

Yes, M2 can build and run both amrv8 and x86_64. As M2 can run anything, there is no favorite target when running, when a Mac machine is available, it will run tests or build binaries as needed.

it will run tests

it won't run any executable built by the tests and protected with if can_run(self): while it could. That's what I meant by "tests could run entirely which is not the case anymore for macOS x86_64 builds".

github-actions · 2023-12-30T07:59:35Z

Hooks produced the following warnings for commit a5cc508

dcmtk/3.6.7@#8c982f28ffe05bda5c49f269005c82c4

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmtkcharls.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmtract.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmjpls.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmpstat.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmect.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmpmap.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmfg.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmjpeg.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/liboflog.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmiod.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmqrdb.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmimage.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmsr.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libofstd.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmseg.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcmr.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmnet.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmrt.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmimgle.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmtls.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmdsig.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmdata.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdcmwlm.so' links to system library 'nsl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libi2d.so' links to system library 'nsl' but it is not in cpp_info.system_libs.

mayeut · 2024-04-13T07:10:35Z

The check rosetta support commit seems useless on CCI Jenkins.
I guess the configuration validity is not checked on macOS M1 ?
That would mean the only option to get macOS x86_64 builds on CCI would be to have tools.build.cross_building:can_run=True in the profile ?

conan-center-bot · 2024-04-19T03:28:41Z

Conan v1 pipeline ✔️

All green in build 3 (858991d02b48899766a216d42c63a71346fd017c):

dcmtk/3.6.8:
All packages built successfully! (All logs)
dcmtk/3.6.7:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (858991d02b48899766a216d42c63a71346fd017c):

dcmtk/3.6.7:
All packages built successfully! (All logs)
dcmtk/3.6.8:
All packages built successfully! (All logs)

jcar87 · 2024-11-22T15:21:06Z

Closing as superseded by #25997

We've addressed the separate issue of crossbuilding on mac by following the advice in the dcmtk documentation.
Note that on an Apple silicon Mac with Rosetta installed, it shouldn't be necessary to coerce CMake into being able to run native code when targetting x86_64 - the recipe as it was before was building fine by passing --setting:host arch=x86_64 --settings:build arch=x86_64- that is, if the system supports running two architectures, tweak the build profile to reflect the one you want to use - that works in most cases I've tried, but if it doesn't please us know. Nevertheless, we've enabled cross-building on macOS as per dcmtk's instructions.

dcmtk: bump deps

fada8c5

This was referenced Dec 27, 2023

[service] Potentially conflicting recipes #3571

Closed

DCMTK: Add dcmect submodule #21020

Closed

prince-chrismc mentioned this pull request Dec 27, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the Failed label Dec 27, 2023

This comment has been minimized.

Sign in to view

dcmtk: fix macOS build with host_arch=x86_64 & build_arch=arm64

a5cc508

Requires rosetta & `tools.build.cross_building:can_run=True`

mayeut commented Dec 28, 2023

View reviewed changes

conan-center-bot removed the Failed label Dec 30, 2023

This comment has been minimized.

Sign in to view

ghost mentioned this pull request Jan 1, 2024

Add dcmtk version 3.6.8 #22099

Closed

3 tasks

AbrilRBS self-assigned this Jan 6, 2024

AbrilRBS requested a review from uilianries January 6, 2024 04:31

ghost mentioned this pull request Jan 7, 2024

dcmtk: add v3.6.8 #22187

Merged

ghost mentioned this pull request Feb 23, 2024

dcmtk: fix compilation error ambiguous overload for operator== with some compilers #20449

Merged

3 tasks

conan-center-bot requested a review from danimtb March 4, 2024 11:41

conan-center-bot requested a review from AbrilRBS April 4, 2024 11:39

Merge branch 'master' into dcmtk-bump-deps

d3e988a

This comment has been minimized.

Sign in to view

check rosetta support

1e3dc38

This comment has been minimized.

Sign in to view

danimtb previously approved these changes Apr 10, 2024

View reviewed changes

mayeut added 2 commits April 18, 2024 20:50

use version range for libxml2 & libpng

a6b5141

Merge branch 'master' into dcmtk-bump-deps

858991d

mayeut dismissed danimtb’s stale review via 858991d April 18, 2024 18:50

conan-center-bot requested a review from danimtb July 8, 2024 11:39

conan-center-bot requested a review from jcar87 August 14, 2024 11:38

jcar87 closed this Nov 22, 2024

mayeut deleted the dcmtk-bump-deps branch November 22, 2024 20:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dcmtk: bump deps #21985

dcmtk: bump deps #21985

mayeut commented Dec 27, 2023

This comment has been minimized.

mayeut Dec 28, 2023

valgur Dec 28, 2023

mayeut Dec 28, 2023

uilianries Dec 28, 2023

mayeut Dec 28, 2023

This comment has been minimized.

github-actions bot commented Dec 30, 2023

This comment has been minimized.

This comment has been minimized.

mayeut commented Apr 13, 2024

conan-center-bot commented Apr 19, 2024

jcar87 commented Nov 22, 2024

dcmtk: bump deps #21985

dcmtk: bump deps #21985

Conversation

mayeut commented Dec 27, 2023

This comment has been minimized.

mayeut Dec 28, 2023

Choose a reason for hiding this comment

valgur Dec 28, 2023

Choose a reason for hiding this comment

mayeut Dec 28, 2023

Choose a reason for hiding this comment

uilianries Dec 28, 2023

Choose a reason for hiding this comment

mayeut Dec 28, 2023

Choose a reason for hiding this comment

This comment has been minimized.

github-actions bot commented Dec 30, 2023

This comment has been minimized.

This comment has been minimized.

mayeut commented Apr 13, 2024

conan-center-bot commented Apr 19, 2024

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

jcar87 commented Nov 22, 2024