Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getdns: migrate to Conan v2, bump to v1.7.3 #21389

Merged
merged 24 commits into from
Sep 6, 2024
Merged

getdns: migrate to Conan v2, bump to v1.7.3 #21389

merged 24 commits into from
Sep 6, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Nov 26, 2023 •
edited
Loading

@prince-chrismc prince-chrismc mentioned this pull request Nov 26, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Nov 26, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Nov 27, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@AbrilRBS AbrilRBS self-assigned this Nov 27, 2023
@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Jan 2, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Jan 20, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Jan 25, 2024
Closed
@conan-center-bot conan-center-bot added Service Under Maintenance and removed Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Feb 21, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot conan-center-bot requested a review from danimtb May 20, 2024 11:42
@uilianries
Use CMAKE_PROJECT_INCLUDE
43b3fc8 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Avoid capturing network on test package
6ed7302 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Remove option for gnutls
163e933 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Remove stub option
c4d999b 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Enable libidn2 by default
53c2c75 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries mentioned this pull request Sep 5, 2024
Open
@uilianries
ignore incompatible pointer type
577421b 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Import libidn2 defines
15f13a4 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member

I did some changes over this PR, including:

  • Replaced cmake wrapper by CMAKE_PROJECT_INCLUDE to include external dependencies
  • Simplified test package to avoid fetching the network
  • Remove option for tls: GnuTLS is only supported on Linux and needs libnuma to work. Checking other package managers, only Gentoo is supporting it, and still, has a separated package for gnutls-numa
  • Remove stub option and configured to True always. Other package managers are using True as well, and CCI has no libunbound available
  • Enable libidn2 by default, following the upstream
  • Injected compiler flag to ignore pointer error on Clang (reported to the upstream)
  • Imported libidn2 definition when building on Windows to avoid linkage error.

@uilianries uilianries self-assigned this Sep 5, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries
Make CMaktoolchain compatible to Conan 1.x
6b548ee 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Merge branch 'master' of https://github.com/conan-io/conan-center-index…
8a7ab17 
… into migrate/getdns
@uilianries
Inject libidn2 defines to executables
2d4af44 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
uilianries
uilianries previously approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valgur
Copy link
Contributor Author

valgur commented Sep 6, 2024

LGTM as well. Thanks!

@uilianries
Add todo comment for future refactor
6092f1d 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (6092f1d143ca2e1f14dcbd1e6cb012cd9434e0d7):

  • getdns/1.7.3:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (6092f1d143ca2e1f14dcbd1e6cb012cd9434e0d7):

  • getdns/1.7.3:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit d1ce33f into conan-io:master Sep 6, 2024
12 checks passed
OMGtechy pushed a commit to OMGtechy/conan-center-index that referenced this pull request Dec 31, 2024
@valgur @uilianries @OMGtechy
(conan-io#21389) getdns: migrate to Conan v2, bump to v1.7.3
974ff0f 
* getdns: migrate to Conan v2

* getdns: bump deps

* getdns: bump to 1.7.3, finish migration

* getdns: temporarily disable libidn2

* getdns: bump cmake, remove pkg-config

* getdns: check that OpenSSL configuration has not failed

* getdns: don't need to use cache_variables

CMake is 3.20+.

* getdns: temporarily print detailed CMake logs

* getdns: add Windows system libs

* getdns: set CMAKE_TRY_COMPILE_CONFIGURATION

* getdns: fix Windows build

* getdns: disable libidn2 for now

* getdns: fix Windows build

* Use CMAKE_PROJECT_INCLUDE

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Avoid capturing network on test package

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Remove option for gnutls

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Remove stub option

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Enable libidn2 by default

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* ignore incompatible pointer type

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Import libidn2 defines

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Make CMaktoolchain compatible to Conan 1.x

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Inject libidn2 defines to executables

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Add todo comment for future refactor

Signed-off-by: Uilian Ries <uilianries@gmail.com>

---------

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@uilianries uilianries uilianries approved these changes

@danimtb danimtb Awaiting requested review from danimtb

@franramirez688 franramirez688 Awaiting requested review from franramirez688

@jcar87 jcar87 Awaiting requested review from jcar87

Assignees

@uilianries uilianries

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@valgur @conan-center-bot @uilianries @AbrilRBS @jwillikers