Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libdisplay-info: move hwdata to build requirements unconditionally + bump hwdata #21246

Merged
merged 4 commits into from
Nov 20, 2024
Merged

libdisplay-info: move hwdata to build requirements unconditionally + bump hwdata #21246

merged 4 commits into from
Nov 20, 2024

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Nov 19, 2023 •
edited
Loading

@prince-chrismc prince-chrismc mentioned this pull request Nov 19, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (4c925ccd5f6d179d3ebce513fd9bba30d9987e56):

  • libdisplay-info/0.1.1:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (4c925ccd5f6d179d3ebce513fd9bba30d9987e56):

  • libdisplay-info/0.1.1:
    All packages built successfully! (All logs)

jwillikers
jwillikers approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@jwillikers jwillikers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@uilianries uilianries self-assigned this Nov 22, 2023
jwillikers
jwillikers approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@jwillikers jwillikers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@conan-center-bot conan-center-bot requested a review from jcar87 June 25, 2024 11:38
@conan-center-bot conan-center-bot requested a review from danimtb July 12, 2024 11:38
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Aug 29, 2024

@uilianries @AbrilRBS @jcar87 @danimtb Could you review this one please? It's waiting for a final reviewer for 9 months 🥲

@perseoGI perseoGI self-assigned this Nov 20, 2024
perseoGI
perseoGI approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcar87 jcar87 merged commit 68f2cfa into conan-io:master Nov 20, 2024
7 checks passed
@SpaceIm SpaceIm deleted the libdisplay-info-hwadata-one-profile branch November 21, 2024 15:52
OMGtechy pushed a commit to OMGtechy/conan-center-index that referenced this pull request Dec 31, 2024
@SpaceIm @perseoGI @OMGtechy
libdisplay-info: move hwdata to build requirements unconditionally + …
c994e32 
…bump hwdata (conan-io#21246)

* move hwdata to build requirements unconditionally

* simplify _has_build_profile

* Some updates

---------

Co-authored-by: PerseoGI <perseog@jfrog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perseoGI perseoGI perseoGI approved these changes

@jwillikers jwillikers jwillikers approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@jcar87 jcar87 jcar87 approved these changes

@valgur valgur valgur approved these changes

@danimtb danimtb Awaiting requested review from danimtb

Assignees

@uilianries uilianries

@perseoGI perseoGI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SpaceIm @conan-center-bot @valgur @jcar87 @AbrilRBS @jwillikers @perseoGI @uilianries