Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xkbcommon: put wayland-protocols in build requirements irrespective of one or dual profile + bump dependencies #21239

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Nov 19, 2023

wayland-protocols is a build requirement and it must be removed from requirements if 1 profile. Requirements (not build requirements) must never depend on settings_build.
The workaround is not manually generate pkgconfig file of wayland-protocols if 1 profile.

See also this discussion #20545 (comment)


Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/xkbcommon//'.

👋 @jwillikers you might be interested. 😉

@SpaceIm SpaceIm force-pushed the fix/xkbcommon-wayland-protocols-one-profile branch from e3507b8 to 492cce0 Compare November 19, 2023 08:55
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Nov 19, 2023

Version conflict in v2 pipeline, should be solved by #21240

@conan-center-bot conan-center-bot added Failed Version conflict There is a version conflict when solving the dependencies graph labels Nov 19, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot removed Failed Version conflict There is a version conflict when solving the dependencies graph labels Nov 19, 2023
@conan-center-bot

This comment has been minimized.

@joakimono joakimono mentioned this pull request Nov 20, 2023
3 tasks
@ghost
Copy link

ghost commented Nov 20, 2023

I detected other pull requests that are modifying xkbcommon/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Dec 26, 2023
3 tasks
@conan-center-bot

This comment has been minimized.

This was referenced Dec 27, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 23, 2024

xkbcommon/0.10.0: Retrieving package 7f0796d38c082e1820c3885fac4cbad263cd7100 from remote 'c3i_PR-21239' 
xkbcommon/0.10.0: WARN: Package binary is corrupted, removing: 7f0796d38c082e1820c3885fac4cbad263cd7100
ERROR: Binary package not found: 'xkbcommon/0.10.0:7f0796d38c082e1820c3885fac4cbad263cd7100'

😢

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 23, 2024

Installing (downloading, building) binaries...
xkbcommon/0.10.0: Retrieving package 7f0796d38c082e1820c3885fac4cbad263cd7100 from remote 'c3i_PR-21239' 
xkbcommon/0.10.0: WARN: Package binary is corrupted, removing: 7f0796d38c082e1820c3885fac4cbad263cd7100
ERROR: Binary package not found: 'xkbcommon/0.10.0:7f0796d38c082e1820c3885fac4cbad263cd7100'

@danimtb @uilianries could you help with this corrupted package in v1 pipeline please?

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 31 (5d20b1f61633efe3dcb50e7290bdc4be0e8447e2):

  • xkbcommon/1.6.0:
    All packages built successfully! (All logs)

  • xkbcommon/1.5.0:
    All packages built successfully! (All logs)

  • xkbcommon/1.3.1:
    All packages built successfully! (All logs)

  • xkbcommon/1.1.0:
    All packages built successfully! (All logs)

  • xkbcommon/0.10.0:
    All packages built successfully! (All logs)

  • xkbcommon/1.4.1:
    All packages built successfully! (All logs)

  • xkbcommon/1.0.3:
    All packages built successfully! (All logs)

  • xkbcommon/1.2.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 29 (5d20b1f61633efe3dcb50e7290bdc4be0e8447e2):

  • xkbcommon/1.5.0:
    All packages built successfully! (All logs)

  • xkbcommon/1.6.0:
    All packages built successfully! (All logs)

  • xkbcommon/1.4.1:
    All packages built successfully! (All logs)

  • xkbcommon/1.3.1:
    All packages built successfully! (All logs)

  • xkbcommon/1.2.1:
    All packages built successfully! (All logs)

  • xkbcommon/1.1.0:
    All packages built successfully! (All logs)

  • xkbcommon/1.0.3:
    All packages built successfully! (All logs)

  • xkbcommon/0.10.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 846e6ad into conan-io:master Feb 8, 2024
53 checks passed
@SpaceIm SpaceIm deleted the fix/xkbcommon-wayland-protocols-one-profile branch February 8, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants