Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freeglut: Add support for Wayland #20905

Merged
merged 14 commits into from
Feb 26, 2024

Conversation

jwillikers
Copy link
Contributor

Specify library name and version: freeglut/*

Adds the with_wayland option to build with support for Wayland.
Both Wayland and X11 support cannot currently be enabled simultaneously for freeglut.
It's weird.

Includes some patches to improve how the dependencies are picked up to avoid pulling in dependencies that aren't provided by Conan.


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 15 (6d394b5451698f92f0e7f1c4b4e66ebb16f5a4c2):

  • freeglut/3.2.1:
    All packages built successfully! (All logs)

  • freeglut/3.4.0:
    All packages built successfully! (All logs)

  • freeglut/3.2.2:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 15 (6d394b5451698f92f0e7f1c4b4e66ebb16f5a4c2):

  • freeglut/3.2.2:
    All packages built successfully! (All logs)

  • freeglut/3.4.0:
    All packages built successfully! (All logs)

  • freeglut/3.2.1:
    All packages built successfully! (All logs)

@AbrilRBS AbrilRBS self-assigned this Nov 14, 2023
@jwillikers
Copy link
Contributor Author

@RubenRBS Can I get a review on this?

@ghost
Copy link

ghost commented Jan 18, 2024

I detected other pull requests that are modifying freeglut/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for sending these patches to the upstream!

@conan-center-bot conan-center-bot merged commit c87d051 into conan-io:master Feb 26, 2024
5 checks passed
@jwillikers jwillikers deleted the freeglut-wayland branch February 26, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants