[google-cloud-cpp] bump requirements and other fixes #20721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I detected other pull requests that are modifying google-cloud-cpp/2.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This was referenced Oct 21, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Hi @coryan sorry for the delay, the PR message made me think it would be automatically merged and I didn't check the contents until now (and realized it wouldn't, so sorry to keep you waiting!) |
AbrilRBS
requested changes
Oct 26, 2023
This comment has been minimized.
This comment has been minimized.
|
Looks like something is broken in the CI? Please let me know if I should take some action. |
Several requirements need version bumps. Where possible I chose version ranges over pinning specific versions. I had to backport fixes for MSVC. I am only guessing, but it seems the toolchain changed in the CI system and now spelling `||` as `or` results in build errors. I also disabled `-Werror` because the code in `v2.5.0` has warnings with newer toolchains. This is to be expected, and that is why the project no longer enables `-Werror` by default.
|
Let's see if it it builds now |
AbrilRBS
approved these changes
Oct 27, 2023
seppeon
pushed a commit
to seppeon/conan-center-index
that referenced
this pull request
Oct 21, 2024
* [google-cloud-cpp] bump requirements and other fixes Several requirements need version bumps. Where possible I chose version ranges over pinning specific versions. I had to backport fixes for MSVC. I am only guessing, but it seems the toolchain changed in the CI system and now spelling `||` as `or` results in build errors. I also disabled `-Werror` because the code in `v2.5.0` has warnings with newer toolchains. This is to be expected, and that is why the project no longer enables `-Werror` by default. * Require host version for gRPC * Starting with v2.12.0 we need a different fix on macOS * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: google-cloud-cpp/v2.5.0 and google-cloud-cpp/v2.12.0.
Several requirements need version bumps. Where possible I chose version ranges over pinning specific versions.
I had to backport fixes for MSVC. I am only guessing, but it seems the toolchain changed in the CI system and now spelling
||asorresults in build errors.I also disabled
-Werrorbecause the code inv2.5.0has warnings with newer toolchains. This is to be expected, and that is why the project no longer enables-Werrorby default.