Recipe/20067 armadillo fix cmake targets #20068

samuel-emrys · 2023-09-21T13:43:22Z

Specify library name and version: armadillo/12.6.4

CMake has a published FindArmadillo.cmake module that defines the filename to be Armadillo and the target to be Armadillo::Armadillo. This is in contrast to the default recipe armadillo::armadillo currently used.

This should be updated to reflect the upstream convention. This recipe builds on top of #19907 so that it builds in conan 2. #19907 should be merged prior to this because of that.

This also sets the following custom cmake variables to align the usage of this package with the upstream cmake module:

ARMADILLO_FOUND - set to true if the library is found
ARMADILLO_INCLUDE_DIRS - list of required include directories
ARMADILLO_LIBRARIES - list of libraries to be linked
ARMADILLO_VERSION_MAJOR - major version number
ARMADILLO_VERSION_MINOR - minor version number
ARMADILLO_VERSION_PATCH - patch version number
ARMADILLO_VERSION_STRING - version number as a string (ex: "1.0.4")
ARMADILLO_VERSION_NAME - name of the version

Closes #20067

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

github-actions · 2023-09-21T13:43:54Z

🤖 Beep Boop! This pull request is making changes to 'recipes/armadillo//'.

👋 @samuel-emrys you might be interested. 😉

github-actions · 2023-09-21T13:44:11Z

🤖 Beep Boop! This pull request is making changes to 'recipes/cmake//'.

👋 @Croydon you might be interested. 😉

github-actions · 2023-09-21T13:44:23Z

🤖 Beep Boop! This pull request is making changes to 'recipes/elfio//'.

👋 @Hopobcn you might be interested. 😉

samuel-emrys · 2023-09-21T13:44:37Z

This obviously brings in too many commits. I'll fix these once the other armadillo PRs are merged.

github-actions · 2023-09-21T13:44:55Z

🤖 Beep Boop! This pull request is making changes to 'recipes/libalsa//'.

👋 @jwillikers you might be interested. 😉

github-actions · 2023-09-21T13:44:58Z

🤖 Beep Boop! This pull request is making changes to 'recipes/libarchive//'.

👋 @jwillikers you might be interested. 😉

github-actions · 2023-09-21T13:45:04Z

🤖 Beep Boop! This pull request is making changes to 'recipes/libcurl//'.

👋 @Hopobcn you might be interested. 😉

github-actions · 2023-09-21T13:45:08Z

🤖 Beep Boop! This pull request is making changes to 'recipes/libdwarf//'.

👋 @Hopobcn you might be interested. 😉

github-actions · 2023-09-21T13:45:21Z

🤖 Beep Boop! This pull request is making changes to 'recipes/libpng//'.

👋 @Hopobcn you might be interested. 😉

github-actions · 2023-09-21T13:45:28Z

🤖 Beep Boop! This pull request is making changes to 'recipes/libunwind//'.

👋 @Hopobcn you might be interested. 😉

github-actions · 2023-09-21T13:45:33Z

🤖 Beep Boop! This pull request is making changes to 'recipes/libxml2//'.

👋 @Hopobcn you might be interested. 😉

github-actions · 2023-09-21T13:45:52Z

🤖 Beep Boop! This pull request is making changes to 'recipes/openssl//'.

👋 @Hopobcn @Croydon you might be interested. 😉

github-actions · 2023-09-21T13:45:55Z

🤖 Beep Boop! This pull request is making changes to 'recipes/protobuf//'.

👋 @Hopobcn you might be interested. 😉

SpaceIm · 2023-09-21T19:36:07Z

CMake has a published FindArmadillo.cmake module that defines the filename to be Armadillo and the target to be Armadillo::Armadillo. This is in contrast to the default recipe armadillo::armadillo currently used.

That's not true for CMake target. See #20067 (comment)

These target names are defined by the public CMake module published by Kitware at https://cmake.org/cmake/help/latest/module/FindArmadillo.html

Add the following legacy CMake variables defined by the upstream FindArmadillo.cmake module published by Kitware - https://cmake.org/cmake/help/latest/module/FindArmadillo.html: * ARMADILLO_FOUND * ARMADILLO_INCLUDE_DIRS * ARMADILLO_LIBRARIES * ARMADILLO_VERSION_MAJOR * ARMADILLO_VERSION_MINOR * ARMADILLO_VERSION_PATCH * ARMADILLO_VERSION_STRING * ARMADILLO_VERSION_NAME

github-actions · 2023-12-05T02:12:02Z

Hooks produced the following warnings for commit f5f1404

armadillo/12.6.4@#99258f7f6c86526c4f323f155fcec8e5

post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/66846/fcced/.conan/data/armadillo/12.6.4/_/_/package/f83ae54dfb18a82abc3b5aed84601da6156de5ce/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files: ./lib/cmake/conan-official-armadillo-variables.cmake
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/66846/efffa/.conan/data/armadillo/12.6.4/_/_/package/3064342dc568993daa08048dd305eec75d8b8361/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/66846/cecda/.conan/data/armadillo/12.6.4/_/_/package/4b4f748ca307c35af345b319d69de65b064ad1e4/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/66846/fcead/.conan/data/armadillo/12.6.4/_/_/package/a8c70666eef94ce7c936220ddb5edbe913c23b14/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/66846/bedea/.conan/data/armadillo/12.6.4/_/_/package/9ac1552f96db92901cd34d133e849423a5ad9e62/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/66846/ccedb/.conan/data/armadillo/12.6.4/_/_/package/8bf12b820b024ddaf86530f89279383f1bb278f1/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/66846/fefae/.conan/data/armadillo/12.6.4/_/_/package/8863722b7758260ec3acc41cce2346f178cec4d7/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/66846/efbea/.conan/data/armadillo/12.6.4/_/_/package/739d3b2f43aad0de964b6f41730ec44340e5d365/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/66846/dcdcc/.conan/data/armadillo/12.6.4/_/_/package/6ec2b4f85686b1eb44ea591fffff36d314743ac9/'}

samuel-emrys · 2023-12-17T22:42:57Z

@SpaceIm @RubenRBS a review would be appreciated, noting my comment in #20067 (comment)

ghost · 2023-12-26T02:22:33Z

I detected other pull requests that are modifying armadillo/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

recipes/armadillo/all/conanfile.py

Add alias targets for wide compatibility with existing CMake scripts. The upstream CMake find module doesn't define what the name of the targets should be, so this provides coverage for the wide usage of different possible combinations found in the wild. This is based on inspection of target_link_library patterns for armadillo usage found on github.

recipes/armadillo/all/conanfile.py

recipes/armadillo/all/test_package/CMakeLists.txt

recipes/armadillo/all/test_v1_package/CMakeLists.txt

… aliases * Make armadillo::armadillo the primary CMake target because the upstream CMake module doesn't enforce this behaviour, and the policy of CCI is to use packagename::packagename when no target is enforced * Make Armadillo::Armadillo and armadillo CMake target aliases as these are common in the wild, and this will facilitate conan package compatibility with existing build scripts. * Remove Armadillo::armadillo and Armadillo as CMake targets as these have not been observed in the wild.

…d reduce aliases" This reverts commit 64016f5.

* Remove Armadillo::armadillo and Armadillo as CMake targets as these have not been observed in the wild.

samuel-emrys · 2024-01-11T08:08:39Z

I've reverted back to using Armadillo::Armadillo as the primary target, as it seems like this is all conan 1.x can support when the module name is FindArmadillo.cmake. I've retained armadillo::armadillo as an alias in conan 2.x, so the net effect is nil in conan 2.x, but using Armadillo::Armadillo as the cmake target allows us to maintain a consistent interface between 1.x, 2.x and upstream.

conan-center-bot · 2024-05-07T18:26:29Z

Conan v1 pipeline ✔️

All green in build 1 (b57d85b658caf01146936b11780f53172c8c18b3):

armadillo/10.7.0:
All packages built successfully! (All logs)
armadillo/10.7.3:
All packages built successfully! (All logs)
armadillo/11.4.3:
All packages built successfully! (All logs)
armadillo/12.6.4:
All packages built successfully! (All logs)
armadillo/12.2.0:
All packages built successfully! (All logs)

github-actions · 2024-05-07T18:27:07Z

Hooks produced the following warnings for commit b57d85b

armadillo/10.7.0@#d4861960525bf94ce0b20f1e37a08ade

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\armadillo.dll' links to system library 'shlwapi' but it is not in cpp_info.system_libs.

armadillo/10.7.3@#c71d65416818656632d0926795124556

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\armadillo.dll' links to system library 'shlwapi' but it is not in cpp_info.system_libs.

armadillo/11.4.3@#3dbfcf0447d376e86bfba24109633ef7

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\armadillo.dll' links to system library 'shlwapi' but it is not in cpp_info.system_libs.

ghost mentioned this pull request Sep 21, 2023

[service] Potentially conflicting recipes #3571

Closed

[armadillo] Fix cmake target names to match upstream

6f9c002

These target names are defined by the public CMake module published by Kitware at https://cmake.org/cmake/help/latest/module/FindArmadillo.html

samuel-emrys force-pushed the recipe/20067-armadillo-fix-cmake-targets branch from d8aeaf7 to 6f9c002 Compare December 5, 2023 00:18

prince-chrismc mentioned this pull request Dec 5, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the Failed label Dec 5, 2023

This comment has been minimized.

Sign in to view

[armadillo] Remove debug messages

f5f1404

This comment has been minimized.

Sign in to view

samuel-emrys added 2 commits December 6, 2023 03:31

[armadillo] Update find_package to use new Armadillo target

fea12f0

[armadillo] Add conan 1.x compatibility for legacy cmake variables

39b309f

conan-center-bot removed the Failed label Dec 5, 2023

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Dec 8, 2023

This comment has been minimized.

Sign in to view

conan-center-bot removed the Service Under Maintenance label Dec 15, 2023

This comment has been minimized.

Sign in to view

ghost mentioned this pull request Dec 26, 2023

armadillo: add v12.6.7, v12.8.1 #21926

Open

ghost mentioned this pull request Jan 6, 2024

[armadillo] Use lapack provided by openblas by default #22174

Merged

3 tasks

valgur approved these changes Jan 8, 2024

View reviewed changes

MartinDelille reviewed Jan 8, 2024

View reviewed changes

recipes/armadillo/all/conanfile.py Show resolved Hide resolved

MartinDelille reviewed Jan 9, 2024

View reviewed changes

MartinDelille approved these changes Jan 10, 2024

View reviewed changes

conan-center-bot added the Failed label Jan 10, 2024

This comment has been minimized.

Sign in to view

samuel-emrys added 2 commits January 11, 2024 18:34

Revert "[armadillo] Make primary CMake target armadillo::armadillo an…

843ac71

…d reduce aliases" This reverts commit 64016f5.

[armadillo] Remove unused cmake target aliases

b57d85b

* Remove Armadillo::armadillo and Armadillo as CMake targets as these have not been observed in the wild.

conan-center-bot removed the Failed label Jan 11, 2024

This comment has been minimized.

Sign in to view

conan-center-bot requested a review from uilianries January 15, 2024 11:51

conan-center-bot requested a review from danimtb April 26, 2024 11:41

danimtb approved these changes May 6, 2024

View reviewed changes

conan-center-bot requested a review from AbrilRBS May 7, 2024 11:41

samuel-emrys requested a review from valgur May 7, 2024 12:43

valgur approved these changes May 7, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

conan-center-bot merged commit 4efceac into conan-io:master May 7, 2024
43 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Recipe/20067 armadillo fix cmake targets #20068

Recipe/20067 armadillo fix cmake targets #20068

samuel-emrys commented Sep 21, 2023 •

edited

Loading

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

samuel-emrys commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

SpaceIm commented Sep 21, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 5, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

samuel-emrys commented Dec 17, 2023

ghost commented Dec 26, 2023 •

edited by ghost

Loading

This comment has been minimized.

samuel-emrys commented Jan 11, 2024

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented May 7, 2024

github-actions bot commented May 7, 2024

Recipe/20067 armadillo fix cmake targets #20068

Recipe/20067 armadillo fix cmake targets #20068

Conversation

samuel-emrys commented Sep 21, 2023 • edited Loading

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

samuel-emrys commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

SpaceIm commented Sep 21, 2023 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 5, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

samuel-emrys commented Dec 17, 2023

ghost commented Dec 26, 2023 • edited by ghost Loading

This comment has been minimized.

samuel-emrys commented Jan 11, 2024

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented May 7, 2024

Conan v1 pipeline ✔️

github-actions bot commented May 7, 2024

samuel-emrys commented Sep 21, 2023 •

edited

Loading

SpaceIm commented Sep 21, 2023 •

edited

Loading

ghost commented Dec 26, 2023 •

edited by ghost

Loading