Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wt: add version 4.10.1 #19989

Merged
merged 5 commits into from
Oct 19, 2023
Merged

wt: add version 4.10.1 #19989

merged 5 commits into from
Oct 19, 2023

Conversation

toge
Copy link
Contributor

@toge toge commented Sep 20, 2023

Specify library name and version: wt/4.10.1


@ghost
Copy link

ghost commented Sep 20, 2023

I detected other pull requests that are modifying wt/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Oct 1, 2023
@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

AbrilRBS commented Oct 2, 2023

Any idea what the issue might be?

@uilianries
Copy link
Member

Any idea what the issue might be?

My guess is some missing support from that compiler version. I'll check locally.

@uilianries
Copy link
Member

Just like I suspected ... Some features of C++ has been removed in C++17 causing compilation errors.

I was able to reproduce the same error as the CI, then I tried with compiler.cppstd=14 and worked.

In that case, we will need check_max_cppstd, but there is a problem: It's not ported to Conan 1.x and will not be ... So we will need a workaround:

# FIXME: check_max_cppstd is only available for Conan 2.x. Remove it after dropping support for Conan 1.x

@conan-center-bot

This comment has been minimized.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member

@toge I was added the workaround with check_max_cppstd. It should fix the Conan 2.x situation.

@conan-center-bot conan-center-bot removed the Bump version PR bumping version without recipe modifications label Oct 18, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (9e41960574a939dac3bdc646a5b6dbd80a6ee548):

  • wt/4.10.0:
    All packages built successfully! (All logs)

  • wt/4.7.1:
    All packages built successfully! (All logs)

  • wt/4.10.1:
    All packages built successfully! (All logs)

  • wt/4.9.1:
    All packages built successfully! (All logs)

  • wt/4.6.2:
    All packages built successfully! (All logs)

  • wt/4.6.0:
    All packages built successfully! (All logs)

  • wt/4.8.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (9e41960574a939dac3bdc646a5b6dbd80a6ee548):

  • wt/4.7.1:
    All packages built successfully! (All logs)

  • wt/4.10.1:
    All packages built successfully! (All logs)

  • wt/4.10.0:
    All packages built successfully! (All logs)

  • wt/4.9.1:
    All packages built successfully! (All logs)

  • wt/4.6.2:
    All packages built successfully! (All logs)

  • wt/4.8.0:
    All packages built successfully! (All logs)

  • wt/4.6.0:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 2a0342f into conan-io:master Oct 19, 2023
5 checks passed
@SpaceIm
Copy link
Contributor

SpaceIm commented Oct 23, 2023

Just like I suspected ... Some features of C++ has been removed in C++17 causing compilation errors.

I was able to reproduce the same error as the CI, then I tried with compiler.cppstd=14 and worked.

In that case, we will need check_max_cppstd, but there is a problem: It's not ported to Conan 1.x and will not be ... So we will need a workaround:

# FIXME: check_max_cppstd is only available for Conan 2.x. Remove it after dropping support for Conan 1.x

Did you report this issue upstream? It's quite unfortunate to have this kind of regression in latest version, specially for conan users for whom default detected profile tends to set cppstd to 17.

@uilianries
Copy link
Member

@SpaceIm no, but looking the upstream, there is a workaround using a define:

emweb/wt@7956a40

@SpaceIm
Copy link
Contributor

SpaceIm commented Oct 23, 2023

So why is there max cppstd? Is it not supposed to work with C++17 and above? This commit is part of 4.10.1

@uilianries
Copy link
Member

Yes, but will need a new PR reverting and passing a new define to the compiler. I'll open it.

@SpaceIm
Copy link
Contributor

SpaceIm commented Oct 23, 2023

Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants