-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wt: add version 4.10.1 #19989
wt: add version 4.10.1 #19989
Conversation
I detected other pull requests that are modifying wt/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Any idea what the issue might be? |
My guess is some missing support from that compiler version. I'll check locally. |
Just like I suspected ... Some features of C++ has been removed in C++17 causing compilation errors. I was able to reproduce the same error as the CI, then I tried with In that case, we will need check_max_cppstd, but there is a problem: It's not ported to Conan 1.x and will not be ... So we will need a workaround:
|
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@toge I was added the workaround with |
Conan v1 pipeline ✔️All green in build 5 (
Conan v2 pipeline ✔️
All green in build 5 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Did you report this issue upstream? It's quite unfortunate to have this kind of regression in latest version, specially for conan users for whom default detected profile tends to set cppstd to 17. |
@SpaceIm no, but looking the upstream, there is a workaround using a define: |
So why is there max cppstd? Is it not supposed to work with C++17 and above? This commit is part of 4.10.1 |
Yes, but will need a new PR reverting and passing a new define to the compiler. I'll open it. |
Thanks 😄 |
Specify library name and version: wt/4.10.1