Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[armadillo] Prevent static builds when use_wrapper=True #19909

Merged
merged 3 commits into from
Oct 4, 2023
Merged

[armadillo] Prevent static builds when use_wrapper=True #19909

merged 3 commits into from
Oct 4, 2023

Conversation

samuel-emrys
Copy link
Contributor

For armadillo to wrap other libraries, these other libraries must be either statically compiled into the armadillo binary or dynamically linked to by libarmadillo. This is not possible when armadillo is a static library itself, without doing some unusual modification of the armadillo archive.

This change ensures that armadillo is built as a shared library when use_wrapper=True, which is the only configuration that would enable libarmadillo to be used this way.

For wider context for what this feature should do, see the armadillo FAQ and read my initial discussion of the problem in #7840.

Closes #7840

@github-actions
Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/armadillo//'.

👋 @samuel-emrys you might be interested. 😉

@ghost ghost mentioned this pull request Sep 17, 2023
Closed
@ghost
Copy link

ghost commented Sep 17, 2023 •
edited by ghost
Loading

I detected other pull requests that are modifying armadillo/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Sep 17, 2023
Merged
3 tasks
@prince-chrismc prince-chrismc mentioned this pull request Sep 17, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@ghost ghost mentioned this pull request Sep 17, 2023
Closed
3 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@samuel-emrys
Copy link
Contributor Author

@RubenRBS could you review this one too please?

AbrilRBS
AbrilRBS previously approved these changes Sep 30, 2023
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it makes sense, thanks a lotf or your patience :)

@AbrilRBS AbrilRBS self-assigned this Sep 30, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
3 similar comments
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
samuel-emrys and others added 3 commits October 1, 2023 20:32
@samuel-emrys
[armadillo] Prevent static builds when use_wrapper=True
6992b3f 
For armadillo to wrap other libraries, these other libraries must be
either statically compiled into the armadillo binary or dynamically
linked to by libarmadillo. This is not possible when armadillo is a
static library itself, without doing some unusual modification of the
armadillo archive.

This change ensures that armadillo is built as a shared library when
use_wrapper=True, which is the only configuration that would enable
libarmadillo to be used this way.

Closes conan-io#7840
@samuel-emrys
[armadillo] Prevent transitive library propagate when use_wrapper=True
e1b338a 
The armadillo run-time library wrapper is designed to provide an opaque
integration with upstream libraries, and so these are not required to be
passed transitively.
@samuel-emrys @SpaceIm
Bump hdf5 version
814e0cf 
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@samuel-emrys samuel-emrys force-pushed the recipe/7840-armadillo-wrapper branch from ece784a to 814e0cf Compare October 1, 2023 10:02
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (814e0cf27706e5ae504aa56e90a8cdcbc2ecbf61):

  • armadillo/10.7.3:
    All packages built successfully! (All logs)

  • armadillo/10.7.0:
    All packages built successfully! (All logs)

  • armadillo/12.2.0:
    All packages built successfully! (All logs)

  • armadillo/11.4.3:
    All packages built successfully! (All logs)

  • armadillo/12.6.4:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (814e0cf27706e5ae504aa56e90a8cdcbc2ecbf61):

  • armadillo/10.7.0:
    All packages built successfully! (All logs)

  • armadillo/10.7.3:
    All packages built successfully! (All logs)

  • armadillo/11.4.3:
    All packages built successfully! (All logs)

  • armadillo/12.2.0:
    All packages built successfully! (All logs)

  • armadillo/12.6.4:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit d48ad2e into conan-io:master Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceIm SpaceIm SpaceIm approved these changes

@jwillikers jwillikers jwillikers approved these changes

@czoido czoido czoido approved these changes

@AbrilRBS AbrilRBS AbrilRBS left review comments

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[package] armadillo/10.7.0: link failures when using use_wrapper=True
6 participants
@samuel-emrys @conan-center-bot @czoido @AbrilRBS @jwillikers @SpaceIm