Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wayland] Conan >=2.0.11 will complain about passing raw options #19621

Conversation

franramirez688
Copy link
Contributor

Specify library name and version: wayland/*

Conan 2.0.11 introduces a check when MesonToolchain receives raw options values directly.
More information related to this issue: conan-io/conan#14453

@franramirez688 franramirez688 changed the title [wayland] Conan >=2.0.11 complains about passing raw options [wayland] Conan >=2.0.11 will complain about passing raw options Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

🤖 Beep Boop! This pull request is making changes to 'recipes/wayland//'.

👋 @jwillikers you might be interested. 😉

@ghost
Copy link

ghost commented Sep 6, 2023

I detected other pull requests that are modifying wayland/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (c45fbc5490a68c815594714017e9cfcc3a71445f):

  • wayland/1.18.0:
    All packages built successfully! (All logs)

  • wayland/1.21.0:
    All packages built successfully! (All logs)

  • wayland/1.19.0:
    All packages built successfully! (All logs)

  • wayland/1.22.0:
    All packages built successfully! (All logs)

  • wayland/1.20.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ❌

Regression: Conan v2 builds are mandatory and they are required for the PR to be merged, because this recipe worked with Conan v2 previously.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 1 (c45fbc5490a68c815594714017e9cfcc3a71445f):

  • wayland/1.21.0:
    Didn't run or was cancelled before finishing

  • wayland/1.22.0:
    Didn't run or was cancelled before finishing

  • wayland/1.18.0:
    Didn't run or was cancelled before finishing

  • wayland/1.20.0:
    CI failed to create some packages (All logs)

    Logs for packageID 043edf4cba7b52083018f38129b2e38fab6d08a8:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=True
    
    [...]
        libiconv/1.17#fa54397801cd96911a8294bc5fc76335 - Cache
        libxml2/2.11.4#0bf4a1077299f970dce106e1a98d2cf9 - Cache
        meson/1.0.0#15586c0ac6f682805875ef903dbe7ee2 - (tp) Cache
        meson/1.1.0#6176e4f21370f5820c27da02836c32c9 - Cache
        ninja/1.11.1#77587f8c8318662ac8e5a7867eb4be21 - (tp) Cache
        pkgconf/1.9.3#5da3944c3226f5764374e4b8b4e1d055 - (tp) Cache
        wayland/1.20.0#d4a52b56d3473f754bd3c099595c693a - Cache
        zlib/1.2.13#97d5730b529b4224045fe7090592d4c1 - Cache
    
    ======== Computing necessary packages ========
    Requirements
        expat/2.5.0#91e43e4544923e4c934bfad1fa4306f9:cb30f6fe72b581624d514ba67bfcf3b85327844a#473ccdfe4e45077157ca7e50c97d5837 - Cache
        libffi/3.4.4#35eb63842b505824b70aedc1baefc916:abe5e2b04ea92ce2ee91bc9834317dbe66628206#df4f691365ba7fff0f3df7a2514eb530 - Cache
        libiconv/1.17#fa54397801cd96911a8294bc5fc76335:abe5e2b04ea92ce2ee91bc9834317dbe66628206#3cbb797095f66828f6f09d715f77cb71 - Cache
        libxml2/2.11.4#0bf4a1077299f970dce106e1a98d2cf9:37481c83dd501d18516491dba69087bcc4d0b658#e685d304f429286b9cfc280622cabd11 - Cache
        wayland/1.20.0#d4a52b56d3473f754bd3c099595c693a:043edf4cba7b52083018f38129b2e38fab6d08a8#38a1530245c4da89c8234f7044e77ce3 - Cache
        zlib/1.2.13#97d5730b529b4224045fe7090592d4c1:abe5e2b04ea92ce2ee91bc9834317dbe66628206#ed677d010310a09789d97d0912b5b79f - Cache
    Build requirements
        pkgconf/1.9.3#5da3944c3226f5764374e4b8b4e1d055:c0b621fd4b3199fe05075171573398833dba85f4#d9eba98c4fc4d0d30a019c9664de2705 - Cache
        wayland/1.20.0#d4a52b56d3473f754bd3c099595c693a:de523cb83b1acaaa061034d5b06c7b2f40d3fe4a - Missing
    Skipped binaries
        expat/2.5.0, libffi/3.4.4, libiconv/1.17, libxml2/2.11.4, meson/1.0.0, meson/1.1.0, ninja/1.11.1, zlib/1.2.13
    
    ======== Installing packages ========
    ERROR: Missing binary: wayland/1.20.0:de523cb83b1acaaa061034d5b06c7b2f40d3fe4a
    
    wayland/1.20.0: WARN: Can't find a 'wayland/1.20.0' package binary 'de523cb83b1acaaa061034d5b06c7b2f40d3fe4a' for the configuration:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.version=11
    os=Linux
    [options]
    enable_dtd_validation=True
    enable_libraries=True
    fPIC=True
    shared=False
    [requires]
    expat/2.5.Z
    libffi/3.4.Z
    libiconv/1.17.Z
    libxml2/2.11.Z
    zlib/1.2.Z
    
    ERROR: Missing prebuilt package for 'wayland/1.20.0'
    Check the available packages using 'conan list wayland/1.20.0:* -r=remote'
    'conan test' tested packages must exist, and '--build' argument is used only for the 'test_package' dependencies, not for the tested dependencies
    
    More Info at 'https://docs.conan.io/2/knowledge/faq.html#error-missing-prebuilt-package'
    
  • wayland/1.19.0:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@franramirez688
Copy link
Contributor Author

After talking to the team, we decided to avoid breaking any recipes because of that.
Reverted the changes on the Conan client side. Now, it'll only show a warning message pointing to the option used directly.

Have a look at this PR: conan-io/conan#14692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants