zlib-ng: provide better compatibility with zlib #19476
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This comment has been minimized.
This comment has been minimized.
| @@ -106,6 +108,12 @@ def package_info(self): | |||
| self.cpp_info.libs = [f"z{suffix}"] | |||
| if self.options.zlib_compat: | |||
| self.cpp_info.defines.append("ZLIB_COMPAT") | |||
| #copied from zlib | |||
There was a problem hiding this comment.
I liked it, but it's not supported by the upstream.
I opened a PR to the upstream asking about it: zlib-ng/zlib-ng#1601
Let's see what is the answer.
There was a problem hiding this comment.
change is available in latest 2.1.6. Should I add this version in this PR?
There was a problem hiding this comment.
2.1.6 was added in other PR. I've rebased my branch on latest master.
|
I detected other pull requests that are modifying zlib-ng/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
2a606ee to
ac96eac
Compare
Conan v1 pipeline ✔️All green in build 8 (
Conan v2 pipeline ✔️
All green in build 8 (
|
Specify library name and version: zlib-ng/all
This change will allow zlib-ng to have same file/target names as zlib.