Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libe57format: add new versions 3.0.[12] #19135

Closed
wants to merge 11 commits into from

Conversation

marxin
Copy link

@marxin marxin commented Aug 10, 2023

The added patch disables LTO as it's not feasible for static libraries where one needs to have exactly the same GCC version (LTO is a bytecode).

Disable E57_BUILD_TEST tests as they want to clone a separate git repository.

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@marxin marxin force-pushed the libe57format-add-new-versions branch from 50642c3 to 4f14b97 Compare August 14, 2023 18:48
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@marxin marxin force-pushed the libe57format-add-new-versions branch from 0caf13c to 3d04ad4 Compare August 15, 2023 07:42
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@marxin marxin force-pushed the libe57format-add-new-versions branch from 15ed8ef to a5b3e77 Compare August 15, 2023 17:54
@conan-center-bot

This comment has been minimized.

@marxin marxin force-pushed the libe57format-add-new-versions branch from a5b3e77 to 77ec2b1 Compare August 16, 2023 05:44
@marxin
Copy link
Author

marxin commented Aug 16, 2023

The package tests fail on MacOS for unknown reason:

======== Testing the package: Executing test ========
libe57format/3.0.2 (test package): Running test()
libe57format/3.0.2 (test package): RUN: ./test_package
libc++abi: terminating with uncaught exception of type e57::E57Exception: E57 exception
/bin/sh: line 1: 68134 Abort trap: 6           ./test_package

Is there a way I can get it merged even w/o the MacOS support?

Plus note the current tests contain deprecated stuff that will be removed in 4.0:

/Users/jenkins/w/prod-v2/BuildSingleReference@2/cci-e7725334/recipes/libe57format/all/test_package/test_package.cpp:10:15: warning: 'Writer' is deprecated: Will be removed in 4.0. Use Writer( ustring, WriterOptions ). [-Wdeprecated-declarations]

@conan-center-bot

This comment has been minimized.

@marxin marxin force-pushed the libe57format-add-new-versions branch from 77ec2b1 to 2915244 Compare August 23, 2023 17:01
@conan-center-bot

This comment has been minimized.

@marxin marxin force-pushed the libe57format-add-new-versions branch from 2915244 to ea4b129 Compare August 24, 2023 05:46
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@marxin marxin force-pushed the libe57format-add-new-versions branch from 772ec04 to 616e325 Compare August 24, 2023 13:12
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 18 (4b13d73f788d15e66cf2f442ba8ae70f96581680):

  • libe57format/2.3.0:
    All packages built successfully! (All logs)

  • libe57format/2.2.0:
    All packages built successfully! (All logs)

  • libe57format/3.0.2:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 18 (4b13d73f788d15e66cf2f442ba8ae70f96581680):

  • libe57format/2.2.0:
    All packages built successfully! (All logs)

  • libe57format/2.3.0:
    All packages built successfully! (All logs)

  • libe57format/3.0.2:
    All packages built successfully! (All logs)

@stale
Copy link

stale bot commented Oct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@marxin marxin closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants