openmpi: migrate to Conan v2 #18980

valgur · 2023-07-31T13:11:29Z

In addition to typical migration changes also:

Adds missing dependencies (requires rdma-core: add new recipe #18978 to be merged).
Adjusts the CMake targets to match the targets exported by FindMPI.cmake.

test_package builds and runs, but displaying of help messages currently fails due to OpenMPI not being able to locate its res folder.

stale · 2023-10-15T11:08:09Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

AbrilRBS · 2023-10-23T06:13:18Z

@valgur any way we can help this one moving along? (Also, could you please set the zlib requirement to the [>=1.2.11 <2] version range? Thanks!)

valgur · 2023-10-23T06:42:48Z

@valgur any way we can help this one moving along? (Also, could you please set the zlib requirement to the [>=1.2.11 <2] version range? Thanks!)

A review of the rdma-core recipe, which is a dependency of this one, would be of great help. I hope the build for that one succeeds now as well. Thanks!

uilianries

LGTM. Thank you!

Validated with C++ enabled and verbs (see this PR to find the build logs)
Still missing CMake variables (https://cmake.org/cmake/help/latest/module/FindMPI.html), but much better than the previous version. Do not need to update it now.

valgur · 2024-09-02T14:46:01Z

@jwillikers Maybe you can give this one a look as well.

recipes/openmpi/all/conanfile.py

uilianries · 2024-09-03T15:43:58Z

I'll still don't have the root cause, but so far:

It does not depends on Conan 1.x. The build fails for Clang on Linux, using the Docker image conanio/clang13-ubuntu16.04:<conan_version>. It fails for both Conan 1.65.0 and 2.7.0.
When hwloc is not listed as requirement, it does not fail.

I'll continue to investigate.

recipes/openmpi/all/conanfile.py

…gure

The current openmpi test package tries to use networking, and in OS like Mac, the GUI asks about permission to execute the test package. It's too much for a simple package validation. It would be better keep a version check for library linkage validation. Signed-off-by: Uilian Ries <uilianries@gmail.com>

Enable again dynamic library build for Mac. With the simplified test package, I see no errors locally for Mac M1. This reverts commit d79c757.

valgur · 2024-09-04T07:07:30Z

Thanks, @uilianries! LGTM.

conan-center-bot · 2024-09-04T07:22:02Z

Conan v1 pipeline ✔️

All green in build 35 (35520e79ec92158492af78c3c7c0aba896bf6dae):

openmpi/4.1.6:
All packages built successfully! (All logs)
openmpi/4.1.0:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 35 (35520e79ec92158492af78c3c7c0aba896bf6dae):

openmpi/4.1.6:
All packages built successfully! (All logs)
openmpi/4.1.0:
All packages built successfully! (All logs)

uilianries · 2024-09-04T07:36:03Z

@valgur I applied few changes related to the test package, I replaced the previous code by a simpler one to avoid networking usage. The CI is more restricted, and probably caused the previous error. In my machine, Mac displayed some pop-ups asking for network permission, which is bad for users.

uilianries

LGTM

addressed

* openmpi: migrate to Conan v2 * openmpi: bump deps * openmpi: do not print created env vars * openmpi: add v4.1.6 * openmpi: improve options coverage * openmpi: fix path env vars * openmpi: fix a PMIX error * openmpi: add MPI::MPI_CXX only if `cxx` is enabled * openmpi: fix static build issues, add external_hwloc option * openmpi: fix libltdl issue, replace AutotoolsDeps with PkgConfigDeps * openmpi: disable buildign of docs * openmpi: drop libltdl dependency * openmpi: external libevent does not really work * openmpi: model components correctly * openmpi: fix pkg-config names * openmpi: disable armv8 for v4.1.0 * openmpi: bump libnl * openmpi: enable with_verbs * openmpi: use REQUIRED CONFIG in test_package for legacy generators * bump rdma-core * openmpi: fix libibverbs.so not being found * openmpi: drop test_v1_package * openmpi: fix apple-clang cross-compilation * openmpi: run autoreconf * openmpi: drop v4.1.0 * openmpi: Revert "run autoreconf" This reverts commit 6f678da. * openmpi: disable Clang on Conan v1 * openmpi: restore v4.1.0 This reverts commit 0461166. * openmpi: add --allow-run-as-root to test_package Co-authored-by: Maksim Petukhov <6967052+maksim-petukhov@users.noreply.github.com> * openmpi: adjust deps * openmpi: enable cxx by default * openmpi: drop external_hwloc option * openmpi: fix an invalid require name * openmpi: add missing requires * openmpi: add VirtualRunEnv to fix ./configure * openmpi: workaround for macOS build failure * openmpi: re-enable Clang/AppleClang for Conan v1 * openmpi: fix_apple_shared_install_name() * openmpi: apply review suggestions * openmpi: drop --with-libevent=internal * openmpi: drop --allow-run-as-root in test_package * openmpi: add a comment for pkg_config_name Co-authored-by: Uilian Ries <uilianries@gmail.com> * openmpi: get_safe("with_verbs") * openmpi: Revert "re-enable Clang/AppleClang for Conan v1" This reverts commit 40d407e. * openmpi: VirtualRunEnv is required to find libhwloc.so during ./configure * openmpi: macOS armv8 fails when shared=True * Simplify test package to avoid networking usage The current openmpi test package tries to use networking, and in OS like Mac, the GUI asks about permission to execute the test package. It's too much for a simple package validation. It would be better keep a version check for library linkage validation. Signed-off-by: Uilian Ries <uilianries@gmail.com> * Revert "openmpi: macOS armv8 fails when shared=True" Enable again dynamic library build for Mac. With the simplified test package, I see no errors locally for Mac M1. This reverts commit d79c757. --------- Signed-off-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Maksim Petukhov <6967052+maksim-petukhov@users.noreply.github.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot added the Service Under Maintenance label Jul 31, 2023

This comment has been minimized.

Sign in to view

valgur mentioned this pull request Aug 1, 2023

[question] MPI and Virtual Packages #18997

Open

conan-center-bot added Failed and removed Service Under Maintenance labels Aug 5, 2023

This comment has been minimized.

Sign in to view

stale bot added the stale label Oct 15, 2023

This was referenced Oct 18, 2023

[service] Potentially conflicting recipes #3571

Closed

Bump openmpi's zlib requirement to [>=1.2.11 <2] range (v1 only) #20671

Closed

AbrilRBS self-assigned this Oct 23, 2023

stale bot removed the stale label Oct 23, 2023

valgur mentioned this pull request Nov 8, 2023

Conan 2.0 migration: the final 100 #20992

Open

valgur added 6 commits December 13, 2023 20:10

openmpi: migrate to Conan v2

7f90c68

openmpi: bump deps

267deb3

openmpi: do not print created env vars

ffc2ff0

openmpi: add v4.1.6

f96412f

openmpi: improve options coverage

83f202d

openmpi: fix path env vars

eea27ca

valgur force-pushed the migrate/openmpi branch from 5924eb7 to eea27ca Compare December 13, 2023 22:32

conan-center-bot added Service Under Maintenance and removed Failed labels Dec 13, 2023

This comment has been minimized.

Sign in to view

openmpi: fix a PMIX error

232a3cc

valgur marked this pull request as ready for review December 13, 2023 22:59

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request Dec 13, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

openmpi: add MPI::MPI_CXX only if cxx is enabled

0405382

This comment has been minimized.

Sign in to view

uilianries previously approved these changes Sep 2, 2024

View reviewed changes

uilianries added the blocked Affected by an external issue and waiting until it is solved label Sep 3, 2024

uilianries reviewed Sep 3, 2024

View reviewed changes

recipes/openmpi/all/conanfile.py Outdated Show resolved Hide resolved

jcar87 previously requested changes Sep 3, 2024

View reviewed changes

recipes/openmpi/all/conanfile.py Outdated Show resolved Hide resolved

uilianries reviewed Sep 3, 2024

View reviewed changes

recipes/openmpi/all/conanfile.py Show resolved Hide resolved

openmpi: VirtualRunEnv is required to find libhwloc.so during ./confi…

586cd9e

…gure

valgur dismissed uilianries’s stale review via 586cd9e September 3, 2024 17:03

conan-center-bot added the Failed label Sep 3, 2024

This comment has been minimized.

Sign in to view

openmpi: macOS armv8 fails when shared=True

d79c757

conan-center-bot removed the Failed label Sep 3, 2024

This comment has been minimized.

Sign in to view

uilianries added 2 commits September 4, 2024 08:54

Revert "openmpi: macOS armv8 fails when shared=True"

35520e7

Enable again dynamic library build for Mac. With the simplified test package, I see no errors locally for Mac M1. This reverts commit d79c757.

uilianries approved these changes Sep 4, 2024

View reviewed changes

uilianries removed the blocked Affected by an external issue and waiting until it is solved label Sep 4, 2024

uilianries requested a review from jcar87 September 4, 2024 07:37

uilianries unassigned AbrilRBS Sep 4, 2024

jwillikers approved these changes Sep 4, 2024

View reviewed changes

conan-center-bot merged commit 30a5ab7 into conan-io:master Sep 5, 2024
16 checks passed

valgur mentioned this pull request Sep 6, 2024

openmpi: add v5.0.5, add optional deps, fix cross-compilation by using GnuToolchain #25162

Open

3 tasks

valgur mentioned this pull request Sep 26, 2024

openmpi: add missing libevent dependency #25431

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

openmpi: migrate to Conan v2 #18980

openmpi: migrate to Conan v2 #18980

valgur commented Jul 31, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

stale bot commented Oct 15, 2023

AbrilRBS commented Oct 23, 2023

valgur commented Oct 23, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

uilianries left a comment

valgur commented Sep 2, 2024

uilianries commented Sep 3, 2024

This comment has been minimized.

This comment has been minimized.

valgur commented Sep 4, 2024

conan-center-bot commented Sep 4, 2024

uilianries commented Sep 4, 2024

uilianries left a comment

openmpi: migrate to Conan v2 #18980

openmpi: migrate to Conan v2 #18980

Conversation

valgur commented Jul 31, 2023 • edited Loading

This comment has been minimized.

This comment has been minimized.

stale bot commented Oct 15, 2023

AbrilRBS commented Oct 23, 2023

valgur commented Oct 23, 2023 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

uilianries left a comment

Choose a reason for hiding this comment

valgur commented Sep 2, 2024

uilianries commented Sep 3, 2024

This comment has been minimized.

This comment has been minimized.

valgur commented Sep 4, 2024

conan-center-bot commented Sep 4, 2024

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

uilianries commented Sep 4, 2024

uilianries left a comment

Choose a reason for hiding this comment

valgur commented Jul 31, 2023 •

edited

Loading

valgur commented Oct 23, 2023 •

edited

Loading