Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foxglove-websocket: Add version 1.1.0 #18885

Merged
merged 8 commits into from
Oct 16, 2023
Merged

Conversation

achim-k
Copy link
Contributor

@achim-k achim-k commented Jul 24, 2023

Specify library name and version: foxglove-websocket/1.1.0


@CLAassistant
Copy link

CLAassistant commented Jul 24, 2023

CLA assistant check
All committers have signed the CLA.

@czoido
Copy link
Contributor

czoido commented Jul 25, 2023

Hi @achim-k,
Thanks a lot for the contribution. Testing this locally, I think this may need self.requires("websocketpp/0.8.2", transitive_headers=True) to build with v2

@achim-k
Copy link
Contributor Author

achim-k commented Jul 25, 2023

Testing this locally, I think this may need self.requires("websocketpp/0.8.2", transitive_headers=True) to build with v2

Do you know an easy way that I can test this locally? The test package includes <foxglove/websocket/websocket_server.hpp> which itself includes websocketpp files, so I guess this is working?

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit fed15c9
foxglove-websocket/1.0.0
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libfoxglove_websocket.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

@czoido czoido self-requested a review July 27, 2023 07:41
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@jtbandes
Copy link
Contributor

Any idea how we can proceed here?

@czoido
Copy link
Contributor

czoido commented Oct 13, 2023

Any idea how we can proceed here?

Hi @jtbandes, I'm going to check the failure now and try to fix and relaunch the PR.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 7dfabe5
foxglove-websocket/1.0.0@#ec20f47cc2a6c6e3a9e384515bd428f1
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libfoxglove_websocket.so' links to system library 'm' but it is not in cpp_info.system_libs.
foxglove-websocket/1.1.0@#d355dc707bfb4897e531e2e3f9e98b50
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libfoxglove_websocket.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (7ae99387b4a53376b993d1757c8657be988dc21c):

  • foxglove-websocket/1.1.0:
    All packages built successfully! (All logs)

  • foxglove-websocket/1.0.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 7 (7ae99387b4a53376b993d1757c8657be988dc21c):

  • foxglove-websocket/1.1.0:
    All packages built successfully! (All logs)

  • foxglove-websocket/1.0.0:
    All packages built successfully! (All logs)

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 7ae9938
foxglove-websocket/1.1.0@#7fe280038d953a3838438c184f82db9d
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libfoxglove_websocket.so' links to system library 'm' but it is not in cpp_info.system_libs.
foxglove-websocket/1.0.0@#48c7acbd8de2bb53b8cb748e8255f134
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libfoxglove_websocket.so' links to system library 'm' but it is not in cpp_info.system_libs.

@defunctzombie
Copy link

@czoido Looks like the builds have all passed.

@czoido
Copy link
Contributor

czoido commented Oct 16, 2023

@czoido Looks like the builds have all passed.

Hi @defunctzombie. Yes, we have to wait for another approval, I'll ping other reviewers so this can be merged soon today. Sorry this took so long.

@conan-center-bot conan-center-bot merged commit d2f965e into conan-io:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants