Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libntv2 library #18621

Closed
wants to merge 7 commits into from
Closed

Conversation

maksim-petukhov
Copy link
Contributor

Specify library name and version: libntv2/cci.20201110

see https://github.com/Esri/ntv2-file-routines/ for description


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (568324519a8d3089d6f665fef9ecf344a807f662):

  • libntv2/cci.20201110@:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 3 (568324519a8d3089d6f665fef9ecf344a807f662):

  • libntv2/cci.20201110@:
    All packages built successfully! (All logs)

@@ -0,0 +1,62 @@
cmake_minimum_required(VERSION 3.15)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please send this CMake file to the upstream as a new pull request there? Even if not accepted, still can have feedback from the author.

Copy link
Contributor Author

@maksim-petukhov maksim-petukhov Aug 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to find time to do this (this CMake can't be sent as is). Is it a blocker for approving this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to avoid patching in CCI as may differ from the original behavior from the upstream and because CCI will become the maintainer of a non-official patch. It's documented here: https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/sources_and_patches.md#policy-about-patching

The libntv2 already offer a Makefile, much more limited, but with some build support at least. So that's why I asking to send to the upstream first, so in case they accept, we will no longer need to patch it here. Or at least, they can provide some feedback.

Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 30, 2024
Copy link
Contributor

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@github-actions github-actions bot closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants