Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xorg] Model uuid dependency #18570

Closed
wants to merge 1 commit into from
Closed

[xorg] Model uuid dependency #18570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions recipes/xorg/all/conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ def validate(self):
def package_id(self):
self.info.clear()

def requirements(self):
# This is necessary to prevent other packages in the dependency tree from using the "libuuid" recipe
# which conflicts with the system installation of `util-linux-libuuid` that `xorg` installs. See #17427, #17485
# This has no functional bearing on xorg, however, as it links against the system library installed in util-linux-libs
self.requires("util-linux-libuuid/2.39")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.requires("util-linux-libuuid/2.39")
self.requires("util-linux-libuuid/[*]")

Could it be set to accept any version, maybe, to avoid the need for version bumps? (the pattern works, I tested it locally)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not opposed to this provided it gets maintainer buy in. @uilianries @RubenRBS thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check: https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/dependencies.md#version-ranges

Conan maintainers may introduce this for other dependencies over time. Outside of the cases outlined above, version ranges are not allowed in ConanCenter recipes.


def system_requirements(self):
apt = package_manager.Apt(self)
apt.install(["libx11-dev", "libx11-xcb-dev", "libfontenc-dev", "libice-dev", "libsm-dev", "libxau-dev", "libxaw7-dev",
Expand Down
Loading