Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wt: bump dependencies and remove old versions #18401

Merged
merged 5 commits into from
Jul 11, 2023

Conversation

jcar87
Copy link
Contributor

@jcar87 jcar87 commented Jul 7, 2023

Specify library name and version: wt/all

  • bump dependencies to more recent versions
  • stop building older versions
  • Ensure that when OpenSSL is required, find_package(OpenSSL) is called - this was somehow commented out in earlier versions of the recipe. When bumping OpenSSL to use a version range that includes >=3, OpenSSL now requires ZLIB and it was not being propagated at link time (in Conan 1.x when building wt:shared=True) because wt was not consuming the Conan-generated targets, despite the information in the recipe being correct. This PR fixes that by restoring the call to find_package(OpenSSL) and ensuring the Conan config is consumed (for good measure, although it's probably not strictly necessary).

From #17512:

  • add package_type
  • remove CMP0077 workaround (related to BUILD_SHARED_LIBS in this context) since it has been fixed in conan 1.54.0

From #17615:

  • add transitive_lib=True for the boost dependency - The public wt headers make transitive inclusions to boost asio.

@ghost
Copy link

ghost commented Jul 7, 2023

I detected other pull requests that are modifying wt/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@jcar87 jcar87 force-pushed the lcc/maintenance/wt-bump-deps branch from d0cb9ef to fb4a21a Compare July 10, 2023 12:56
@jcar87 jcar87 marked this pull request as ready for review July 10, 2023 14:39
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (5828ae322539d3df87f55ad1bf1c48e9c7d946a2):

  • wt/4.9.1@:
    All packages built successfully! (All logs)

  • wt/4.8.0@:
    All packages built successfully! (All logs)

  • wt/4.6.0@:
    All packages built successfully! (All logs)

  • wt/4.7.1@:
    All packages built successfully! (All logs)

  • wt/4.6.2@:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 4 (5828ae322539d3df87f55ad1bf1c48e9c7d946a2):

  • wt/4.6.2@:
    All packages built successfully! (All logs)

  • wt/4.7.1@:
    All packages built successfully! (All logs)

  • wt/4.8.0@:
    All packages built successfully! (All logs)

  • wt/4.6.0@:
    All packages built successfully! (All logs)

  • wt/4.9.1@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit f847b03 into conan-io:master Jul 11, 2023
@jcar87 jcar87 deleted the lcc/maintenance/wt-bump-deps branch July 11, 2023 08:47
amrox pushed a commit to exyntech/conan-center-index that referenced this pull request Jul 12, 2023
* wt: bump dependencies and remove old versions

* remove CMP0077 workaround

it's fixed in conan >= 1.54.0

* add package_type

* wt: add transitive_headers = True for boost dependency

* wt: fix openssl/zlib linking issues

---------

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Co-authored-by: Pero Skoko <pero.skoko@gmail.com>
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jul 15, 2023
* wt: bump dependencies and remove old versions

* remove CMP0077 workaround

it's fixed in conan >= 1.54.0

* add package_type

* wt: add transitive_headers = True for boost dependency

* wt: fix openssl/zlib linking issues

---------

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Co-authored-by: Pero Skoko <pero.skoko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants