(#17449) Use self.info.settings.os in source() method #18351

EstebanDugueperoux2 · 2023-07-05T18:53:46Z

Use self.info.settings.os instead of self.settings.os in source() method to avoid a "ConanException: 'self.settings' access in 'source()' method is forbidden"

Specify library name and version: lib/1.0

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

- Use self.info.settings.os instead of self.settings.os in source() method to avoid a "ConanException: 'self.settings' access in 'source()' method is forbidden"

github-actions · 2023-07-05T18:55:07Z

🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'.

👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉

ghost · 2023-07-05T19:11:56Z

I detected other pull requests that are modifying qt/6.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

conan-center-bot · 2023-07-06T07:15:06Z

Conan v1 pipeline ✔️

All green in build 2 (38b924b39003b2c79ca068fad1683bd12d36648a):

qt/6.5.1@:
All packages built successfully! (All logs)
qt/6.4.2@:
All packages built successfully! (All logs)
qt/6.5.0@:
All packages built successfully! (All logs)
qt/6.3.2@:
All packages built successfully! (All logs)
qt/6.4.1@:
All packages built successfully! (All logs)

Conan v2 pipeline ❌

Note: Conan v2 builds may be required once they are on the v2 ready list

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 1 (38b924b39003b2c79ca068fad1683bd12d36648a):

qt/6.5.0@:
Didn't run or was cancelled before finishing
qt/6.5.1@:
Didn't run or was cancelled before finishing
qt/6.3.2@:
Didn't run or was cancelled before finishing

qt/6.4.2@:
CI failed to create some packages (All logs)

Logs for packageID 7a340d0cb6479b2b0d5ec641f5a4e38f66d1b74c:

[settings]
arch=x86_64
build_type=Release
compiler=apple-clang
compiler.cppstd=17
compiler.libcxx=libc++
compiler.version=13
os=Macos
[options]
*/*:shared=True

********************************************************************************
conan test cci-c9940c46/recipes/qt/6.x.x/test_package/conanfile.py qt/6.4.2@#81dff43672f5d7c441be5e6c20870568 -pr:h /Users/jenkins/w/prod-v2/BuildSingleReference/85382/efe1ee59-0ee0-4451-9c87-1128130cba71/profile_osx_13_libcpp_17_apple-clang_release_64.-shared-True.txt -c:h tools.system.package_manager:mode=install -c:h tools.system.package_manager:sudo=True -c:h tools.apple:sdk_path=/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -pr:b /Users/jenkins/w/prod-v2/BuildSingleReference/85382/efe1ee59-0ee0-4451-9c87-1128130cba71/profile_osx_13_libcpp_17_apple-clang_release_64..txt -c:b tools.system.package_manager:mode=install -c:b tools.system.package_manager:sudo=True -c:b tools.apple:sdk_path=/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk
********************************************************************************

======== Input profiles ========
Profile host:
[settings]
arch=x86_64
build_type=Release
compiler=apple-clang
compiler.cppstd=17
compiler.libcxx=libc++
compiler.version=13
os=Macos
[options]
*/*:shared=True
[conf]
tools.system.package_manager:mode=install
tools.system.package_manager:sudo=True
tools.apple:sdk_path=/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk

Profile build:
[settings]
arch=x86_64
build_type=Release
compiler=apple-clang
compiler.cppstd=17
compiler.libcxx=libc++
compiler.version=13
os=Macos
[conf]
tools.system.package_manager:mode=install
tools.system.package_manager:sudo=True
tools.apple:sdk_path=/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk

ERROR: Error loading conanfile at '/Users/jenkins/w/prod-v2/BuildSingleReference/cci-c9940c46/recipes/qt/6.x.x/test_package/conanfile.py': Unable to load conanfile in /Users/jenkins/w/prod-v2/BuildSingleReference/cci-c9940c46/recipes/qt/6.x.x/test_package/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/Users/jenkins/w/prod-v2/BuildSingleReference/cci-c9940c46/recipes/qt/6.x.x/test_package/conanfile.py", line 10, in <module>
    from conans import tools, Meson, RunEnvironment, CMake
ImportError: cannot import name 'tools' from 'conans' (/Users/jenkins/env_py_3_7_conan_2_0_6/lib/python3.7/site-packages/conans/__init__.py)

qt/6.4.1@:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

github-actions · 2023-07-06T07:15:22Z

Hooks produced the following warnings for commit 38b924b

qt/6.3.2

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt6Widgets.dll' links to system library 'uxtheme' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\styles\qwindowsvistastyle.dll' links to system library 'uxtheme' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\platforms\qdirect2d.dll' links to system library 'd3d9' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\platforms\qwindows.dll' links to system library 'd3d9' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt6Core.dll' links to system library 'mpr' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\sqldrivers\qsqlodbc.dll' links to system library 'odbc32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\platforms\qdirect2dd.dll' links to system library 'd3d9' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\platforms\qwindowsd.dll' links to system library 'd3d9' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt6Cored.dll' links to system library 'mpr' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt6Widgetsd.dll' links to system library 'uxtheme' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\styles\qwindowsvistastyled.dll' links to system library 'uxtheme' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\sqldrivers\qsqlodbcd.dll' links to system library 'odbc32' but it is not in cpp_info.system_libs.

ericLemanissier · 2023-07-06T07:21:40Z

@EstebanDugueperoux2 I integrated your change into my PR: #17942

EstebanDugueperoux2 · 2023-07-06T07:26:24Z

@EstebanDugueperoux2 I integrated your change into my PR: #17942

From CI feedback, I see that test_package has reference to conans package from conan 1.x.
And I find strange to find reference to old generators in this test_package.

ericLemanissier · 2023-07-06T07:35:48Z

Yes, nobody ported the test package to conan 2 yet. Don't hesitate to do it

ericLemanissier · 2023-07-10T10:55:25Z

FYI, I ported the test package to conan 2 in #17942. It should be merged shortly (just a team review is missing). Can you please close this PR @EstebanDugueperoux2 in order to avoid useless builds ?

ericLemanissier · 2023-07-18T11:57:07Z

#17942 is now merged. this PR is now a no-op and can be closed @EstebanDugueperoux2

(conan-io#17449) Use self.info.settings.os in source() method

38b924b

- Use self.info.settings.os instead of self.settings.os in source() method to avoid a "ConanException: 'self.settings' access in 'source()' method is forbidden"

This was referenced Jul 5, 2023

[service] Potentially conflicting recipes #3571

Closed

[qt/6.4.3] Add version #17951

Closed

qt6: bump deps #17942

Merged

[qt/6.x.x] Fix conan toolchain #17925

Merged

prince-chrismc mentioned this pull request Jul 5, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the Unexpected Error label Jul 6, 2023

This comment has been minimized.

Sign in to view

conan-center-bot removed the Unexpected Error label Jul 6, 2023

MartinDelille approved these changes Jul 6, 2023

View reviewed changes

ghost mentioned this pull request Jul 7, 2023

qt: fix ConanV2 compat on Windows #18404

Closed

3 tasks

ghost mentioned this pull request Jul 18, 2023

qt/6.x.x: bump deps #18614

Merged

3 tasks

EstebanDugueperoux2 closed this Jul 18, 2023

EstebanDugueperoux2 deleted the feature/Fix17449 branch July 18, 2023 13:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(#17449) Use self.info.settings.os in source() method #18351

(#17449) Use self.info.settings.os in source() method #18351

EstebanDugueperoux2 commented Jul 5, 2023

github-actions bot commented Jul 5, 2023

ghost commented Jul 5, 2023 •

edited by ghost

Loading

This comment has been minimized.

conan-center-bot commented Jul 6, 2023

github-actions bot commented Jul 6, 2023

ericLemanissier commented Jul 6, 2023

EstebanDugueperoux2 commented Jul 6, 2023

ericLemanissier commented Jul 6, 2023

ericLemanissier commented Jul 10, 2023

ericLemanissier commented Jul 18, 2023

(#17449) Use self.info.settings.os in source() method #18351

(#17449) Use self.info.settings.os in source() method #18351

Conversation

EstebanDugueperoux2 commented Jul 5, 2023

github-actions bot commented Jul 5, 2023

ghost commented Jul 5, 2023 • edited by ghost Loading

This comment has been minimized.

conan-center-bot commented Jul 6, 2023

Conan v1 pipeline ✔️

Conan v2 pipeline ❌

github-actions bot commented Jul 6, 2023

ericLemanissier commented Jul 6, 2023

EstebanDugueperoux2 commented Jul 6, 2023

ericLemanissier commented Jul 6, 2023

ericLemanissier commented Jul 10, 2023

ericLemanissier commented Jul 18, 2023

ghost commented Jul 5, 2023 •

edited by ghost

Loading