Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccache: add version 4.8.2 #18315

Merged
merged 3 commits into from
Jul 20, 2023
Merged

ccache: add version 4.8.2 #18315

merged 3 commits into from
Jul 20, 2023

Conversation

Cogitri
Copy link
Contributor

@Cogitri Cogitri commented Jul 4, 2023

Also update the dependencies

Specify library name and version: ccache/4.8.2


@ghost
Copy link

ghost commented Jul 4, 2023

I detected other pull requests that are modifying ccache/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jcar87
Copy link
Contributor

jcar87 commented Jul 14, 2023

The build errors appear to be a manifestation of ccache/ccache#1278, for which there is a patch that made it to 4.8.2 - I will backport and reference this.

@jcar87 jcar87 self-assigned this Jul 14, 2023
@Cogitri
Copy link
Contributor Author

Cogitri commented Jul 14, 2023

Ah grand, thanks

@jcar87
Copy link
Contributor

jcar87 commented Jul 14, 2023

Hi @Cogitri - I did not have permission to push to your branch, so I've opened an independent PR to fix the build issue.

#18542

Feel free to cherry-pick the commit from my branch into this PR if you would like this new version and the version bumps to be merged quicker - otherwise once/if my PR is merged first, you can rebase your PR to sync up with the latest changes.

Also thanks for fixing the issue with zstd! very nice catch

@ghost ghost mentioned this pull request Jul 14, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

jcar87
jcar87 previously requested changes Jul 18, 2023
Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

In order to fix the build errors on Windows, please add the following in the generate() method:

deps.set_property("zstd", "cmake_find_mode", "module")

which should make the tool_requires on pkgconf unnecessary

@jcar87 jcar87 dismissed their stale review July 19, 2023 09:16

changes applied

Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution!

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (46c9fde3c856c4626f85f327f292826dea0f0db4):

  • ccache/4.7.4@:
    All packages built successfully! (All logs)

  • ccache/4.8.1@:
    All packages built successfully! (All logs)

  • ccache/4.8@:
    All packages built successfully! (All logs)

  • ccache/4.8.2@:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 8 (46c9fde3c856c4626f85f327f292826dea0f0db4):

  • ccache/4.8@:
    All packages built successfully! (All logs)

  • ccache/4.7.4@:
    All packages built successfully! (All logs)

  • ccache/4.8.1@:
    All packages built successfully! (All logs)

  • ccache/4.8.2@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit d7da970 into conan-io:master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants