-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccache: add version 4.8.2 #18315
ccache: add version 4.8.2 #18315
Conversation
I detected other pull requests that are modifying ccache/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The build errors appear to be a manifestation of ccache/ccache#1278, for which there is a patch that made it to |
Ah grand, thanks |
Hi @Cogitri - I did not have permission to push to your branch, so I've opened an independent PR to fix the build issue. Feel free to cherry-pick the commit from my branch into this PR if you would like this new version and the version bumps to be merged quicker - otherwise once/if my PR is merged first, you can rebase your PR to sync up with the latest changes. Also thanks for fixing the issue with zstd! very nice catch |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Also update the dependencies
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
In order to fix the build errors on Windows, please add the following in the generate()
method:
deps.set_property("zstd", "cmake_find_mode", "module")
which should make the tool_requires on pkgconf unnecessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution!
Conan v1 pipeline ✔️All green in build 8 (
Conan v2 pipeline ✔️
All green in build 8 ( |
Also update the dependencies
Specify library name and version: ccache/4.8.2