Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avahi: add package_type, set cmake_target_name, pkg_config_name #18196

Merged
merged 7 commits into from
Sep 6, 2023
Merged

avahi: add package_type, set cmake_target_name, pkg_config_name #18196

merged 7 commits into from
Sep 6, 2023

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jun 30, 2023

No description provided.

@github-actions
Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/avahi//'.

👋 @jwillikers you might be interested. 😉

jwillikers
jwillikers suggested changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@jwillikers jwillikers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I understand adding package_type, but why remove the V1 test package and why are the cmake_targe_name and pkg_config_name properties necessary to set? Are no defaults generated? Can you update your description with that information?

recipes/avahi/all/conanfile.py Outdated Show resolved Hide resolved
@valgur valgur closed this Jul 3, 2023
@valgur valgur reopened this Jul 4, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur closed this Jul 8, 2023
@valgur valgur reopened this Jul 8, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur requested a review from jwillikers July 17, 2023 21:21
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc prince-chrismc mentioned this pull request Jul 17, 2023
Open
jwillikers
jwillikers reviewed Jul 20, 2023
View reviewed changes
Copy link
Contributor

@jwillikers jwillikers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question on Conan V1 compatibility. Everything else looks perfect. Thanks!

recipes/avahi/all/conanfile.py Show resolved Hide resolved
@valgur valgur closed this Jul 21, 2023
@valgur valgur reopened this Jul 21, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur closed this Aug 16, 2023
@valgur valgur reopened this Aug 16, 2023
AbrilRBS
AbrilRBS previously approved these changes Aug 16, 2023
View reviewed changes
@AbrilRBS AbrilRBS self-assigned this Aug 16, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@jwillikers
Copy link
Contributor

It might be something to do with bumping the dbus dependency, as this PR fixes #19271.

jcar87
jcar87 previously approved these changes Aug 21, 2023
View reviewed changes
This was referenced Aug 24, 2023
Closed
Closed
@ghost
Copy link

ghost commented Aug 24, 2023 •
edited by ghost
Loading

I detected other pull requests that are modifying avahi/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@danimtb danimtb mentioned this pull request Aug 28, 2023
Merged
5 tasks
@AbrilRBS
Copy link
Member

Im having problems trying to build dbus locally to test this yeah :/

@ericLemanissier ericLemanissier mentioned this pull request Aug 30, 2023
Merged
3 tasks
@ghost ghost mentioned this pull request Aug 31, 2023
Closed
3 tasks
@valgur valgur dismissed stale reviews from jcar87 and AbrilRBS via 1572ec0 September 5, 2023 09:06
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (1572ec0f75dfac32249736ee9c04934a8dc179b8):

  • avahi/0.8:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (1572ec0f75dfac32249736ee9c04934a8dc179b8):

  • avahi/0.8:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit a558cc0 into conan-io:master Sep 6, 2023
ericLemanissier added a commit to ericLemanissier/conan-center-index that referenced this pull request Sep 15, 2023
@valgur @ericLemanissier
(conan-io#18196) avahi: add package_type, set cmake_target_name, pkg_…
a40e2e2 
…config_name

* avahi: add package_type, set cmake_target_name, pkg_config_name

* avahi: restore test_v1_package

* avahi: bump deps

* avahi: remove redundant cmake_target_name for components

* avahi: improve os detection

* avahi: bump deps

* fix conan 2

---------

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@danimtb danimtb danimtb approved these changes

@ericLemanissier ericLemanissier ericLemanissier approved these changes

@SSE4 SSE4 SSE4 approved these changes

@AbrilRBS AbrilRBS AbrilRBS left review comments

@jcar87 jcar87 jcar87 left review comments

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@valgur @conan-center-bot @jwillikers @AbrilRBS @SSE4 @ericLemanissier @jcar87 @danimtb