Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openh264: Use profile ndk_path instead of enviroment #18070

Merged
merged 4 commits into from
Jul 3, 2023
Merged

openh264: Use profile ndk_path instead of enviroment #18070

merged 4 commits into from
Jul 3, 2023

Conversation

LevWi
Copy link
Contributor

@LevWi LevWi commented Jun 27, 2023 •
edited
Loading

openh264/x.x.x

Build for Android require ANDROID_NDK_HOME in terminal environment. We have more convenient way to set this variable

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@LevWi LevWi changed the title Use profile ndk_path instead of enviroment openh264: Use profile ndk_path instead of enviroment Jun 27, 2023
@LevWi LevWi marked this pull request as ready for review June 27, 2023 07:40
@prince-chrismc prince-chrismc mentioned this pull request Jun 27, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@jcar87
Copy link
Contributor

jcar87 commented Jun 27, 2023

Hi @LevWi - thanks for your contribution. Please be aware that contributors need to review the CLA: Details.

Thanks!

@jcar87 jcar87 self-assigned this Jun 27, 2023
@prince-chrismc prince-chrismc mentioned this pull request Jun 28, 2023
Merged
jcar87
jcar87 previously approved these changes Jun 30, 2023
View reviewed changes
@conan-center-bot

This comment has been minimized.

Sign in to view
@jcar87
Copy link
Contributor

jcar87 commented Jun 30, 2023

Hi @LevWi - please be advised that once CI passes it is not necessary (and often counter productive) to continue syncing with the master branch. Our system is prepared to handle an eventual commit landing on the master branch for the same recipe already.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (d66c75168055e4d9e7bf4383e55568bd3ba651e5):

  • openh264/1.7.0@:
    All packages built successfully! (All logs)

  • openh264/2.3.1@:
    All packages built successfully! (All logs)

  • openh264/2.1.1@:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 4 (d66c75168055e4d9e7bf4383e55568bd3ba651e5):

  • openh264/2.3.1@:
    All packages built successfully! (All logs)

  • openh264/2.1.1@:
    All packages built successfully! (All logs)

  • openh264/1.7.0@:
    All packages built successfully! (All logs)

@LevWi
Copy link
Contributor Author

LevWi commented Jun 30, 2023

@jcar87

Sorry :)

@conan-center-bot conan-center-bot merged commit 708a2ec into conan-io:master Jul 3, 2023
tannerbitz pushed a commit to tannerbitz/conan-center-index that referenced this pull request Jul 8, 2023
@LevWi @tannerbitz
(conan-io#18070) openh264: Use profile ndk_path instead of enviroment
9c51a16
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jul 15, 2023
@LevWi @pezy
(conan-io#18070) openh264: Use profile ndk_path instead of enviroment
cc5f803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czoido czoido czoido approved these changes

@jcar87 jcar87 jcar87 approved these changes

Assignees

@jcar87 jcar87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LevWi @CLAassistant @conan-center-bot @jcar87 @czoido